Skip to content

Add test for skipObject with an argument #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

dhaiducek
Copy link
Contributor

ref: https://issues.redhat.com/browse/ACM-19753
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
@dhaiducek
Copy link
Contributor Author

/cherry-pick release-2.13

@openshift-cherrypick-robot

@dhaiducek: once the present PR merges, I will cherry-pick it on top of release-2.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Apr 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, JustinKuli, yiraeChristineKim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JustinKuli,dhaiducek,yiraeChristineKim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhaiducek
Copy link
Contributor Author

/test remaining-required

@yiraeChristineKim
Copy link
Contributor

/test test-e2e-grc-framework

@dhaiducek
Copy link
Contributor Author

/override "ci/prow/test-e2e-grc-framework"

Flaky failure:

 GRC: [P1][Sev1][policy-grc] Test install Operator When all defaults are used on the subscription test-op-47229 should be created and become compliant [BVT]
/go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_install_operator_test.go:513
  STEP: Verifying that the policy policy-test/test-op-47229 is Compliant @ 04/09/25 14:57:02.037
  [FAILED] in [It] - /go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_install_operator_test.go:517 @ 04/09/25 14:59:02.037
  STEP: Cleaning up the operator installation @ 04/09/25 14:59:02.037
  STEP: Verifying that the policy policy-test/cleanup-grcqeoptest-ns is Compliant @ 04/09/25 14:59:02.502
• [FAILED] [122.020 seconds]
GRC: [P1][Sev1][policy-grc] Test install Operator When all defaults are used on the subscription [It] test-op-47229 should be created and become compliant [BVT]
/go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_install_operator_test.go:513
  [FAILED] Timed out after 120.000s.
  The function passed to Eventually failed at /go/src/github.com/stolostron/governance-policy-framework/test/integration/utils_test.go:53 with:
  Expected
      <string>: NonCompliant
  to equal
      <string>: Compliant
  In [It] at: /go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_install_operator_test.go:517 @ 04/09/25 14:59:02.037 

But my test passed:

 GRC: [P1][Sev1][policy-grc] Test objectSelector and context variables Using skipObject with an argument should report the correct status
/go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_selector_test.go:137
  STEP: DoCreatePolicyTest creates ../resources/policy_selector/policy-selector.yaml on namespace policy-test @ 04/09/25 14:54:07.414
  STEP: DoCreatePolicyTest OcHub apply output: policy.policy.open-cluster-management.io/policy-selector configured
  placementbinding.policy.open-cluster-management.io/policy-selector-pb unchanged
  placement.cluster.open-cluster-management.io/policy-selector-plr unchanged
   @ 04/09/25 14:54:08.004
  STEP: Checking policy-test.policy-selector on managed cluster in ns managed-1 @ 04/09/25 14:54:08.017
  STEP: Checking that the policy template policy.open-cluster-management.io/v1, Resource=configurationpolicies/policy-selector is present on the managed cluster @ 04/09/25 14:54:08.03
  STEP: Patching skipObject to use an argument @ 04/09/25 14:54:08.044
  STEP: Patching the objectSelector @ 04/09/25 14:54:08.241
  STEP: Checking the status @ 04/09/25 14:54:08.432 

Copy link

openshift-ci bot commented Apr 9, 2025

@dhaiducek: Overrode contexts on behalf of dhaiducek: ci/prow/test-e2e-grc-framework

In response to this:

/override "ci/prow/test-e2e-grc-framework"

Flaky failure:

GRC: [P1][Sev1][policy-grc] Test install Operator When all defaults are used on the subscription test-op-47229 should be created and become compliant [BVT]
/go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_install_operator_test.go:513
 STEP: Verifying that the policy policy-test/test-op-47229 is Compliant @ 04/09/25 14:57:02.037
 [FAILED] in [It] - /go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_install_operator_test.go:517 @ 04/09/25 14:59:02.037
 STEP: Cleaning up the operator installation @ 04/09/25 14:59:02.037
 STEP: Verifying that the policy policy-test/cleanup-grcqeoptest-ns is Compliant @ 04/09/25 14:59:02.502
• [FAILED] [122.020 seconds]
GRC: [P1][Sev1][policy-grc] Test install Operator When all defaults are used on the subscription [It] test-op-47229 should be created and become compliant [BVT]
/go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_install_operator_test.go:513
 [FAILED] Timed out after 120.000s.
 The function passed to Eventually failed at /go/src/github.com/stolostron/governance-policy-framework/test/integration/utils_test.go:53 with:
 Expected
     <string>: NonCompliant
 to equal
     <string>: Compliant
 In [It] at: /go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_install_operator_test.go:517 @ 04/09/25 14:59:02.037 

But my test passed:

GRC: [P1][Sev1][policy-grc] Test objectSelector and context variables Using skipObject with an argument should report the correct status
/go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_selector_test.go:137
 STEP: DoCreatePolicyTest creates ../resources/policy_selector/policy-selector.yaml on namespace policy-test @ 04/09/25 14:54:07.414
 STEP: DoCreatePolicyTest OcHub apply output: policy.policy.open-cluster-management.io/policy-selector configured
 placementbinding.policy.open-cluster-management.io/policy-selector-pb unchanged
 placement.cluster.open-cluster-management.io/policy-selector-plr unchanged
  @ 04/09/25 14:54:08.004
 STEP: Checking policy-test.policy-selector on managed cluster in ns managed-1 @ 04/09/25 14:54:08.017
 STEP: Checking that the policy template policy.open-cluster-management.io/v1, Resource=configurationpolicies/policy-selector is present on the managed cluster @ 04/09/25 14:54:08.03
 STEP: Patching skipObject to use an argument @ 04/09/25 14:54:08.044
 STEP: Patching the objectSelector @ 04/09/25 14:54:08.241
 STEP: Checking the status @ 04/09/25 14:54:08.432 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dhaiducek
Copy link
Contributor Author

/override ci/prow/images

Copy link

openshift-ci bot commented Apr 10, 2025

@dhaiducek: Overrode contexts on behalf of dhaiducek: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit f2acc5b into stolostron:main Apr 10, 2025
9 checks passed
@openshift-cherrypick-robot

@dhaiducek: new pull request created: #924

In response to this:

/cherry-pick release-2.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants