Skip to content

fix: Added hyphen to allowed characters in tool name validation #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025

Conversation

xiehust
Copy link
Contributor

@xiehust xiehust commented May 20, 2025

Description

Added hyphen to allowed characters in tool name validation, to support tavily search mcp server with tool names as "tavily-search" and "tavily-extract"

Related Issues

#54

Documentation PR

[Link to related associated PR in the agent-docs repo]

Type of Change

  • Bug fix

Testing

yes

  • hatch fmt --linter
  • hatch fmt --formatter
  • hatch test --all
  • Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

Checklist

  • I have read the CONTRIBUTING document
  • I have added tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@xiehust xiehust requested a review from a team as a code owner May 20, 2025 06:25
@Unshure Unshure assigned zastrowm and unassigned pgrayy May 27, 2025
@zastrowm
Copy link
Member

Sorry about the delay here - we just want to perform some testing with other providers.

We'll have a follow up task/bug to fix regarding direct tool calls that won't work with dashes, but we won't block merging on that.

@zastrowm zastrowm self-requested a review May 28, 2025 14:08
@zastrowm zastrowm enabled auto-merge (squash) May 29, 2025 00:35
@zastrowm zastrowm merged commit a2bb881 into strands-agents:main May 29, 2025
10 of 20 checks passed
@zastrowm
Copy link
Member

Thanks for the fix for #54

jer96 pushed a commit to lukehau/sdk-python that referenced this pull request Jun 3, 2025
…nds-agents#55)

* Added hyphen to allowed characters in tool name validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants