Skip to content

fix: Added hyphen to allowed characters in tool name validation #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025
Merged

fix: Added hyphen to allowed characters in tool name validation #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
877e56a
Added hyphen to allowed characters in tool name validation
xiehust May 20, 2025
49af95b
fix: Added hyphen to allowed characters for tool name validation
xiehust May 20, 2025
1638f21
fix: improve readability of test tool code
xiehust May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/strands/tools/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def validate_tool_use_name(tool: ToolUse) -> None:
raise InvalidToolUseNameException(message)

tool_name = tool["name"]
tool_name_pattern = r"^[a-zA-Z][a-zA-Z0-9_]*$"
tool_name_pattern = r"^[a-zA-Z][a-zA-Z0-9_\-]*$"
tool_name_max_length = 64
valid_name_pattern = bool(re.match(tool_name_pattern, tool_name))
tool_name_len = len(tool_name)
Expand Down
8 changes: 6 additions & 2 deletions tests/strands/tools/test_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,13 @@


def test_validate_tool_use_name_valid():
tool = {"name": "valid_tool_name", "toolUseId": "123"}
tool1 = {"name": "valid_tool_name", "toolUseId": "123"}
# Should not raise an exception
validate_tool_use_name(tool1)

tool2 = {"name": "valid-name", "toolUseId": "123"}
# Should not raise an exception
validate_tool_use_name(tool)
validate_tool_use_name(tool2)


def test_validate_tool_use_name_missing():
Expand Down
Loading