From bad9f478e0c2bfd017519eea190d86fb27fe3445 Mon Sep 17 00:00:00 2001 From: Jamie Howard Date: Wed, 20 Nov 2024 15:47:50 +0000 Subject: [PATCH 01/17] chore: basic github ci --- .github/ISSUE_TEMPLATE/BUG_REPORT.yml | 38 ++++++++++++ .github/ISSUE_TEMPLATE/FEATURE_REQUEST.yml | 22 +++++++ .github/PULL_REQUEST_TEMPLATE.md | 15 +++++ .github/workflows/issues_dailyCron.yml | 30 ++++++++++ .github/workflows/issues_handleLabel.yml | 67 ++++++++++++++++++++++ 5 files changed, 172 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/BUG_REPORT.yml create mode 100644 .github/ISSUE_TEMPLATE/FEATURE_REQUEST.yml create mode 100644 .github/PULL_REQUEST_TEMPLATE.md create mode 100644 .github/workflows/issues_dailyCron.yml create mode 100644 .github/workflows/issues_handleLabel.yml diff --git a/.github/ISSUE_TEMPLATE/BUG_REPORT.yml b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml new file mode 100644 index 0000000..83f190f --- /dev/null +++ b/.github/ISSUE_TEMPLATE/BUG_REPORT.yml @@ -0,0 +1,38 @@ +name: 🐛 Bug Report +description: Create a report to help us improve this repo. +title: '[bug]: ' +labels: ['issue: bug'] +body: + - type: markdown + attributes: + value: | + Thank you for filing a bug report! + - type: textarea + attributes: + label: What version of `@strapi/sdk-js` are you using? + placeholder: | + - Npm version + - Node.js version + - React version: + - `@strapi/sdk-js` version + - Browser + validations: + required: true + - type: textarea + attributes: + label: "What's Wrong?" + description: A concise description of what you expected to happen (please provide screenshots). + validations: + required: true + - type: textarea + attributes: + label: To Reproduce + description: Steps to reproduce the behavior + validations: + required: true + - type: textarea + attributes: + label: Expected Behaviour + description: What you expected to happen + validations: + required: true diff --git a/.github/ISSUE_TEMPLATE/FEATURE_REQUEST.yml b/.github/ISSUE_TEMPLATE/FEATURE_REQUEST.yml new file mode 100644 index 0000000..cf4bfbb --- /dev/null +++ b/.github/ISSUE_TEMPLATE/FEATURE_REQUEST.yml @@ -0,0 +1,22 @@ +name: 🚀 Feature Request +description: Submit a request for a new feature +title: '[feat]: ' +labels: ['issue: enhancement'] +body: + - type: markdown + attributes: + value: | + Thank you for contributing a feature request! + - type: textarea + attributes: + label: A clear and concise description of what the feature is + validations: + required: true + - type: textarea + attributes: + label: Why should this feature be included? + validations: + required: true + - type: textarea + attributes: + label: Please provide an example for how this would work diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000..f940ac9 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,15 @@ +### What does it do? + +Describe the technical changes you did. + +### Why is it needed? + +Describe the issue you are solving. + +### How to test it? + +Provide information about the environment and the path to verify the behaviour. + +### Related issue(s)/PR(s) + +Let us know if this is related to any issue/pull request diff --git a/.github/workflows/issues_dailyCron.yml b/.github/workflows/issues_dailyCron.yml new file mode 100644 index 0000000..d230cbb --- /dev/null +++ b/.github/workflows/issues_dailyCron.yml @@ -0,0 +1,30 @@ +name: 'Daily Cron - 00:00' + +on: + schedule: + - cron: '0 0 * * *' + +permissions: + issues: write + statuses: read + +jobs: + cron-tasks: + runs-on: ubuntu-latest + steps: + - name: check for inactive issues that can't be reproduced + uses: actions-cool/issues-helper@v3 + with: + actions: 'close-issues' + token: ${{ secrets.GITHUB_TOKEN }} + labels: 'status: can not reproduce' + inactive-day: 14 + close-reason: 'completed' + body: | + Hello! + + As we have not received any new or updated information to reproduce this issue in the last 14 days we are marking this issue as closed. Should you have new information please feel free to respond and we will consider reopening it. + + If anyone else has updated information for this issue, please open up a new bug report and simply reference this closed bug report so that we can get any new information you may have. If you have questions please refer to the [contributor's guide](https://github.com/strapi/strapi/blob/main/CONTRIBUTING.md#reporting-an-issue) on opening issues. + + Thank you and have a great day! diff --git a/.github/workflows/issues_handleLabel.yml b/.github/workflows/issues_handleLabel.yml new file mode 100644 index 0000000..66d4906 --- /dev/null +++ b/.github/workflows/issues_handleLabel.yml @@ -0,0 +1,67 @@ +name: Issue Labeled + +on: + issues: + types: [labeled] + +permissions: + issues: write + pull-requests: write + actions: read + checks: read + contents: read + repository-projects: read + statuses: read + +jobs: + issue-labeled: + runs-on: ubuntu-latest + steps: + # Unable to Reproduce Tasks + - name: 'Comment: unable to reproduce' + if: "${{ github.event.label.name == 'status: can not reproduce' }}" + uses: actions-cool/issues-helper@v3 + with: + actions: 'create-comment' + token: ${{ secrets.GITHUB_TOKEN }} + issue-number: ${{ github.event.issue.number }} + body: | + > This is a templated message + + Hello @${{ github.event.issue.user.login }}, + + Thank you for reporting this bug, however we are unable to reproduce the issue you described given the information we have on hand. Can you please create a fresh project that you are able to reproduce the issue in, provide clear steps to reproduce this issue, and either upload this fresh project to a new GitHub repo or compress it into a `.zip` and upload it on this issue? + + We would greatly appreciate your assistance with this, by working in a fresh project it will cut out any possible variables that might be unrelated. + Please note that issues labeled with `status: can not reproduce` will be closed in 14 days if there is no activity. + + Thank you! + + # Invalid bug report template actions + - name: 'Comment: invalid bug report template' + if: "${{ github.event.label.name == 'flag: invalid template' }}" + uses: actions-cool/issues-helper@v3 + with: + actions: 'create-comment' + token: ${{ secrets.GITHUB_TOKEN }} + issue-number: ${{ github.event.issue.number }} + body: | + > This is a templated message + + Hello @${{ github.event.issue.user.login }}, + + We ask that you please follow the [issue template](https://raw.githubusercontent.com/strapi/strapi/master/.github/ISSUE_TEMPLATE/BUG_REPORT.md). + A proper issue submission let's us better understand the origin of your bug and therefore help you. We will reopen your issue when we receive the issue following the template guidelines and properly fill out the template. You can see the template guidelines for bug reports [here](https://github.com/strapi/strapi/blob/master/CONTRIBUTING.md#reporting-an-issue). + + Please update the issue with the template and we can reopen this report. + + Thank you. + + - name: 'Close: invalid bug report template' + if: "${{ github.event.label.name == 'flag: invalid template' }}" + uses: actions-cool/issues-helper@v3 + with: + actions: 'close-issue' + token: ${{ secrets.GITHUB_TOKEN }} + issue-number: ${{ github.event.issue.number }} + close-reason: 'not_planned' From e8d09c3032fc4ddc0310bfdbbcf7eff870a3466d Mon Sep 17 00:00:00 2001 From: Convly Date: Tue, 26 Nov 2024 15:32:19 +0100 Subject: [PATCH 02/17] chore: add gh workflows for issue handling, tests, and commit linting --- .github/filters.yml | 2 + .github/workflows/commitlint.yml | 25 ++++++++ .github/workflows/issues_handleLabel.yml | 31 +++++++++- .github/workflows/tests.yml | 75 ++++++++++++++++++++++++ 4 files changed, 132 insertions(+), 1 deletion(-) create mode 100644 .github/filters.yml create mode 100644 .github/workflows/commitlint.yml create mode 100644 .github/workflows/tests.yml diff --git a/.github/filters.yml b/.github/filters.yml new file mode 100644 index 0000000..223f7cc --- /dev/null +++ b/.github/filters.yml @@ -0,0 +1,2 @@ +unit: + - 'tests/unit/**/*.(ts)' diff --git a/.github/workflows/commitlint.yml b/.github/workflows/commitlint.yml new file mode 100644 index 0000000..109817f --- /dev/null +++ b/.github/workflows/commitlint.yml @@ -0,0 +1,25 @@ +name: 'Commitlint' + +on: + push: + branches: + - main + pull_request: + +permissions: + contents: read # to fetch code (actions/checkout) + actions: read + +jobs: + commitlint: + runs-on: ubuntu-22.04 + steps: + - uses: actions/checkout@v4 + with: + fetch-depth: 0 + - uses: actions/setup-node@v4 + with: + node-version: 20 + - name: Validate PR commits with commitlint + if: github.event_name == 'pull_request' + run: npx commitlint --from ${{ github.event.pull_request.base.sha }} --to ${{ github.event.pull_request.head.sha }} --verbose diff --git a/.github/workflows/issues_handleLabel.yml b/.github/workflows/issues_handleLabel.yml index 66d4906..a56f3ed 100644 --- a/.github/workflows/issues_handleLabel.yml +++ b/.github/workflows/issues_handleLabel.yml @@ -2,7 +2,7 @@ name: Issue Labeled on: issues: - types: [labeled] + types: [ labeled ] permissions: issues: write @@ -65,3 +65,32 @@ jobs: token: ${{ secrets.GITHUB_TOKEN }} issue-number: ${{ github.event.issue.number }} close-reason: 'not_planned' + # Redirect questions to community sources + - name: 'Comment: redirect question to community' + if: "${{ github.event.label.name == 'flag: question' }}" + uses: actions-cool/issues-helper@v3 + with: + actions: 'create-comment' + token: ${{ secrets.GITHUB_TOKEN }} + issue-number: ${{ github.event.issue.number }} + body: | + > This is a templated message + + Hello @${{ github.event.issue.user.login }}, + + I see you are wanting to ask a question that is not really a bug report, + + - questions should be directed to [our forum](https://forum.strapi.io) or our [Discord](https://discord.strapi.io) + - feature requests should be directed to our [feedback and feature request database](https://feedback.strapi.io) + + Please see the following contributing guidelines for asking a question [here](https://github.com/strapi/strapi/blob/master/CONTRIBUTING.md#reporting-an-issue). + + Thank you. + - name: 'Close: redirect question to community' + if: "${{ github.event.label.name == 'flag: question' }}" + uses: actions-cool/issues-helper@v3 + with: + actions: 'close-issue' + token: ${{ secrets.GITHUB_TOKEN }} + issue-number: ${{ github.event.issue.number }} + close-reason: 'complete' diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml new file mode 100644 index 0000000..56b17f6 --- /dev/null +++ b/.github/workflows/tests.yml @@ -0,0 +1,75 @@ +name: 'Tests' + +on: + push: + branches: + - main + pull_request: + +permissions: + contents: read # to fetch code (actions/checkout) + actions: read + +jobs: + changes: + runs-on: ubuntu-latest + permissions: + pull-requests: read + outputs: + unit: ${{ steps.filter.outputs.unit }} + steps: + - uses: actions/checkout@v4 + with: + fetch-depth: 0 + - uses: dorny/paths-filter@v3 + id: filter + with: + filters: .github/filters.yaml + + cache-and-install: + runs-on: ubuntu-latest + + strategy: + matrix: + node: [20, 22] + + steps: + - name: Checkout + uses: actions/checkout@v4 + + - uses: pnpm/action-setup@v4 + name: Install pnpm + with: + version: 9 + run_install: false + + - name: Install Node.js + uses: actions/setup-node@v4 + with: + node-version: ${{ matrix.node }} + cache: 'pnpm' + + build: + name: 'build (node: ${{ matrix.node }})' + runs-on: ubuntu-latest + strategy: + matrix: + node: [20, 22] + steps: + - name: Project build + shell: bash + run: pnpm run build:clean + + unit_back: + if: needs.changes.outputs.backend == 'true' + name: 'unit_back (node: ${{ matrix.node }})' + needs: [ changes, build ] + runs-on: ubuntu-latest + env: + YARN_ENABLE_IMMUTABLE_INSTALLS: false + strategy: + matrix: + node: [ 20, 22 ] + steps: + - name: Run tests + run: yarn nx affected --target=test:unit --nx-ignore-cycles From 7c18c0c9417f87272b067a5888ad552e57600eab Mon Sep 17 00:00:00 2001 From: Convly Date: Tue, 26 Nov 2024 15:34:10 +0100 Subject: [PATCH 03/17] chore: update pnpm version to 9.1.0 in GitHub Actions --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 56b17f6..eaa684e 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -40,7 +40,7 @@ jobs: - uses: pnpm/action-setup@v4 name: Install pnpm with: - version: 9 + version: 9.1.0 run_install: false - name: Install Node.js From aa0c47bb3ba7bd6d2cb217eb0146528633fad0bd Mon Sep 17 00:00:00 2001 From: Convly Date: Tue, 26 Nov 2024 15:36:06 +0100 Subject: [PATCH 04/17] chore: add dependency on cache-and-install step in build job --- .github/workflows/tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index eaa684e..4cba1f5 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -51,6 +51,7 @@ jobs: build: name: 'build (node: ${{ matrix.node }})' + needs: [cache-and-install] runs-on: ubuntu-latest strategy: matrix: From baf97a3facb5fc15a894817499eb4863282de839 Mon Sep 17 00:00:00 2001 From: Convly Date: Tue, 26 Nov 2024 15:40:21 +0100 Subject: [PATCH 05/17] chore: switch to using pnpx for commitlint --- .github/workflows/commitlint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/commitlint.yml b/.github/workflows/commitlint.yml index 109817f..5deb2dd 100644 --- a/.github/workflows/commitlint.yml +++ b/.github/workflows/commitlint.yml @@ -22,4 +22,4 @@ jobs: node-version: 20 - name: Validate PR commits with commitlint if: github.event_name == 'pull_request' - run: npx commitlint --from ${{ github.event.pull_request.base.sha }} --to ${{ github.event.pull_request.head.sha }} --verbose + run: pnpx commitlint --from ${{ github.event.pull_request.base.sha }} --to ${{ github.event.pull_request.head.sha }} --verbose From 80c169e2577fcd492767966dafb4ee14846edd24 Mon Sep 17 00:00:00 2001 From: Convly Date: Tue, 26 Nov 2024 15:43:01 +0100 Subject: [PATCH 06/17] chore: run installation with token access --- .github/workflows/tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 4cba1f5..6b4ac65 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -21,6 +21,7 @@ jobs: - uses: actions/checkout@v4 with: fetch-depth: 0 + token: ${{ secrets.GITHUB_TOKEN }} - uses: dorny/paths-filter@v3 id: filter with: From 3b45cfadc46d02f764cab2bbe81e0eb8540a45bf Mon Sep 17 00:00:00 2001 From: Convly Date: Tue, 26 Nov 2024 15:44:14 +0100 Subject: [PATCH 07/17] chore: make sure pnpm is available for commitlint --- .github/workflows/commitlint.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/commitlint.yml b/.github/workflows/commitlint.yml index 5deb2dd..363d95c 100644 --- a/.github/workflows/commitlint.yml +++ b/.github/workflows/commitlint.yml @@ -20,6 +20,11 @@ jobs: - uses: actions/setup-node@v4 with: node-version: 20 + - uses: pnpm/action-setup@v4 + name: Install pnpm + with: + version: 9.1.0 + run_install: false - name: Validate PR commits with commitlint if: github.event_name == 'pull_request' run: pnpx commitlint --from ${{ github.event.pull_request.base.sha }} --to ${{ github.event.pull_request.head.sha }} --verbose From d9b41577d27325b70f6dd956a190dbb34948e7a3 Mon Sep 17 00:00:00 2001 From: Convly Date: Tue, 26 Nov 2024 15:46:37 +0100 Subject: [PATCH 08/17] chore: enable pnpm installation in commitlint workflow --- .github/workflows/commitlint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/commitlint.yml b/.github/workflows/commitlint.yml index 363d95c..8c221b9 100644 --- a/.github/workflows/commitlint.yml +++ b/.github/workflows/commitlint.yml @@ -24,7 +24,7 @@ jobs: name: Install pnpm with: version: 9.1.0 - run_install: false + run_install: true - name: Validate PR commits with commitlint if: github.event_name == 'pull_request' run: pnpx commitlint --from ${{ github.event.pull_request.base.sha }} --to ${{ github.event.pull_request.head.sha }} --verbose From f2260e7bf5334f78ee3bf09da08b4b96fde7bf1b Mon Sep 17 00:00:00 2001 From: Convly Date: Tue, 26 Nov 2024 15:48:37 +0100 Subject: [PATCH 09/17] chore: set pnpm to auto-install in GitHub Actions workflow --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 6b4ac65..0174a11 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -42,7 +42,7 @@ jobs: name: Install pnpm with: version: 9.1.0 - run_install: false + run_install: true - name: Install Node.js uses: actions/setup-node@v4 From e25258367dd29c8e6910ae704d5cd9ebbb0b041b Mon Sep 17 00:00:00 2001 From: Convly Date: Tue, 26 Nov 2024 15:51:33 +0100 Subject: [PATCH 10/17] chore: remove unused token from GitHub Actions checkout --- .github/workflows/tests.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 0174a11..3a5a1bd 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -21,7 +21,6 @@ jobs: - uses: actions/checkout@v4 with: fetch-depth: 0 - token: ${{ secrets.GITHUB_TOKEN }} - uses: dorny/paths-filter@v3 id: filter with: From 919f5a8320e11b55d756085aa6bfb136deedd3a9 Mon Sep 17 00:00:00 2001 From: Convly Date: Tue, 26 Nov 2024 15:53:28 +0100 Subject: [PATCH 11/17] chore: remove the unused 'changes' job from tests.yml --- .github/workflows/tests.yml | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 3a5a1bd..e22bd24 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -11,21 +11,6 @@ permissions: actions: read jobs: - changes: - runs-on: ubuntu-latest - permissions: - pull-requests: read - outputs: - unit: ${{ steps.filter.outputs.unit }} - steps: - - uses: actions/checkout@v4 - with: - fetch-depth: 0 - - uses: dorny/paths-filter@v3 - id: filter - with: - filters: .github/filters.yaml - cache-and-install: runs-on: ubuntu-latest @@ -64,7 +49,7 @@ jobs: unit_back: if: needs.changes.outputs.backend == 'true' name: 'unit_back (node: ${{ matrix.node }})' - needs: [ changes, build ] + needs: [ build ] runs-on: ubuntu-latest env: YARN_ENABLE_IMMUTABLE_INSTALLS: false From ab34b0638bc2db907ed501139124bda50d60cce4 Mon Sep 17 00:00:00 2001 From: Convly Date: Tue, 26 Nov 2024 15:54:52 +0100 Subject: [PATCH 12/17] chore: update dependencies for backend unit tests --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index e22bd24..b6cdf20 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -49,7 +49,7 @@ jobs: unit_back: if: needs.changes.outputs.backend == 'true' name: 'unit_back (node: ${{ matrix.node }})' - needs: [ build ] + needs: [ cache-and-install, build ] runs-on: ubuntu-latest env: YARN_ENABLE_IMMUTABLE_INSTALLS: false From 0f990311eadc65188218ff74641d0a833de63062 Mon Sep 17 00:00:00 2001 From: Convly Date: Tue, 26 Nov 2024 15:56:44 +0100 Subject: [PATCH 13/17] chore: add pnpm setup and node version installation in CI --- .github/workflows/tests.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index b6cdf20..8473769 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -57,5 +57,20 @@ jobs: matrix: node: [ 20, 22 ] steps: + - name: Checkout + uses: actions/checkout@v4 + + - uses: pnpm/action-setup@v4 + name: Install pnpm + with: + version: 9.1.0 + run_install: true + + - name: Install Node.js + uses: actions/setup-node@v4 + with: + node-version: ${{ matrix.node }} + cache: 'pnpm' + - name: Run tests run: yarn nx affected --target=test:unit --nx-ignore-cycles From 38c167a3060ef1f81a8509a111513ad024497087 Mon Sep 17 00:00:00 2001 From: Convly Date: Tue, 26 Nov 2024 15:58:27 +0100 Subject: [PATCH 14/17] chore: add setup steps for pnpm and Node.js versions 20 and 22 --- .github/workflows/tests.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 8473769..b93236b 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -42,6 +42,21 @@ jobs: matrix: node: [20, 22] steps: + - name: Checkout + uses: actions/checkout@v4 + + - uses: pnpm/action-setup@v4 + name: Install pnpm + with: + version: 9.1.0 + run_install: true + + - name: Install Node.js + uses: actions/setup-node@v4 + with: + node-version: ${{ matrix.node }} + cache: 'pnpm' + - name: Project build shell: bash run: pnpm run build:clean From f9bb21678c0ba53be5cc9af9e6267bff30f3df7c Mon Sep 17 00:00:00 2001 From: Convly Date: Tue, 26 Nov 2024 16:00:15 +0100 Subject: [PATCH 15/17] chore: update tests workflow to use pnpm instead of yarn --- .github/workflows/tests.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index b93236b..1a33159 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -66,8 +66,6 @@ jobs: name: 'unit_back (node: ${{ matrix.node }})' needs: [ cache-and-install, build ] runs-on: ubuntu-latest - env: - YARN_ENABLE_IMMUTABLE_INSTALLS: false strategy: matrix: node: [ 20, 22 ] @@ -88,4 +86,4 @@ jobs: cache: 'pnpm' - name: Run tests - run: yarn nx affected --target=test:unit --nx-ignore-cycles + run: pnpm run test From b7b5d32e55930fd5145478bcd1637fe73b432255 Mon Sep 17 00:00:00 2001 From: Convly Date: Tue, 26 Nov 2024 16:22:59 +0100 Subject: [PATCH 16/17] chore: remove conditional check on unit_back job in CI --- .github/workflows/tests.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 1a33159..f56d464 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -62,7 +62,6 @@ jobs: run: pnpm run build:clean unit_back: - if: needs.changes.outputs.backend == 'true' name: 'unit_back (node: ${{ matrix.node }})' needs: [ cache-and-install, build ] runs-on: ubuntu-latest From 628ee2f4a55abdbc9818a50650c29286674bdc55 Mon Sep 17 00:00:00 2001 From: Convly Date: Tue, 26 Nov 2024 16:24:51 +0100 Subject: [PATCH 17/17] chore: remove pnpm cache setting from GitHub Actions workflow --- .github/workflows/tests.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index f56d464..e4844ad 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -32,7 +32,6 @@ jobs: uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} - cache: 'pnpm' build: name: 'build (node: ${{ matrix.node }})'