fix(url-helper): fix url query params transformation #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Replace the custom URL search params transformation (from custom to using qs).
Using qs for now to match what's used/expected on the Strapi server side.
This doubles the bundles size, this is to be expected for now. Added a
todoto make sure we replace the library in the short term with a lighter version. (see ljharb/qs#404 for more info)Why is it needed?
The custom query param manipulation was not working for deeply nested queries.
See #41
How to test it?
See reproduction steps on #41
Related issue(s)/PR(s)
fix #41