Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HighlightGenerator form translations #5309

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gettinToasty
Copy link
Contributor

This allows translators to more effectively translate these fields with languages that have different sentence structures from English

Copy link

bundlemon bot commented Feb 18, 2025

BundleMon

Files updated (1)
Status Path Size Limits
renderer.(hash).js
7.08MB (+396B +0.01%) -
Unchanged files (3)
Status Path Size Limits
vendors~renderer.(hash).js
4.67MB -
updater.js
115.29KB -
guest-api.js
40.19KB -

Total files change +396B 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

</Select>
</div>
</Translate>
</h3>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the h3 is wrapping everything? Should it be that way?

'Create highlight video of <roundSelect></roundSelect> with a duration of <minutesSelect></minutesSelect>',
)}
>
<div slot="roundSelect">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the rendered version the roundSelect and minuteSelect slots are empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants