Removed checkstyle (#136)

streamnative · Apr 26, 2024 · 900e073 · 900e073
1 parent e1df766
commit 900e073
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 281 deletions.
diff --git a/README.md b/README.md
@@ -26,7 +26,6 @@ Common build actions:
 | Full build and test             | `mvn clean verify`                       |
 | Skip tests                      | `mvn clean verify -DskipTests`           |
 | Skip Jacoco test coverage check | `mvn clean verify -Djacoco.skip`         |
-| Skip Checkstyle standards check | `mvn clean verify -Dcheckstyle.skip`     |
 | Skip Spotless formatting check  | `mvn clean verify -Dspotless.check.skip` |
 | Format code                     | `mvn spotless:apply`                     |
 | Generate license headers        | `mvn license:format`                     |

diff --git a/etc/checkstyle.xml b/etc/checkstyle.xml
diff --git a/pom.xml b/pom.xml
@@ -94,7 +94,6 @@
 
         <assertj.version>3.24.1</assertj.version>
         <awaitility.version>3.0.0</awaitility.version>
-        <checkstyle.version>10.12.5</checkstyle.version>
         <lombok.version>1.18.30</lombok.version>
         <slf4j.version>1.7.32</slf4j.version>
         <junit.jupiter.version>5.9.2</junit.jupiter.version>
@@ -103,7 +102,6 @@
         <testcontainers.version>1.17.6</testcontainers.version>
         <guava.version>32.1.3-jre</guava.version>
 
-        <checkstyle.plugin.version>3.3.1</checkstyle.plugin.version>
         <jacoco.plugin.version>0.8.8</jacoco.plugin.version>
         <license.plugin.version>4.1</license.plugin.version>
         <maven.compiler.plugin.version>3.10.1</maven.compiler.plugin.version>
@@ -314,34 +312,6 @@
                     </execution>
                 </executions>
             </plugin>
-            <plugin>
-                <!-- Deeper code style check -->
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-checkstyle-plugin</artifactId>
-                <version>${checkstyle.plugin.version}</version>
-                <configuration>
-                    <consoleOutput>true</consoleOutput>
-                    <failOnViolation>true</failOnViolation>
-                    <failsOnError>true</failsOnError>
-                    <configLocation>etc/checkstyle.xml</configLocation>
-                    <includeTestSourceDirectory>true</includeTestSourceDirectory>
-                </configuration>
-                <dependencies>
-                    <dependency>
-                        <groupId>com.puppycrawl.tools</groupId>
-                        <artifactId>checkstyle</artifactId>
-                        <version>${checkstyle.version}</version>
-                    </dependency>
-                </dependencies>
-                <executions>
-                    <execution>
-                        <goals>
-                            <goal>check</goal>
-                        </goals>
-                        <phase>validate</phase>
-                    </execution>
-                </executions>
-            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-enforcer-plugin</artifactId>

diff --git a/pulsar-metadatastore-oxia/pom.xml b/pulsar-metadatastore-oxia/pom.xml
@@ -38,12 +38,10 @@
 
         <pulsar.version>3.0.2</pulsar.version>
 
-        <checkstyle.version>10.3.3</checkstyle.version>
         <testng.version>7.7.0</testng.version>
         <dropwizard.version>4.1.12.1</dropwizard.version>
         <snappy.version>1.1.10.4</snappy.version>
 
-        <checkstyle.plugin.version>3.2.0</checkstyle.plugin.version>
         <jacoco.plugin.version>0.8.8</jacoco.plugin.version>
         <license.plugin.version>4.1</license.plugin.version>
         <maven.compiler.plugin.version>3.10.1</maven.compiler.plugin.version>
@@ -223,34 +221,6 @@
                     </execution>
                 </executions>
             </plugin>
-            <plugin>
-                <!-- Deeper code style check -->
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-checkstyle-plugin</artifactId>
-                <version>${checkstyle.plugin.version}</version>
-                <configuration>
-                    <consoleOutput>true</consoleOutput>
-                    <failOnViolation>true</failOnViolation>
-                    <failsOnError>true</failsOnError>
-                    <configLocation>etc/checkstyle.xml</configLocation>
-                    <includeTestSourceDirectory>true</includeTestSourceDirectory>
-                </configuration>
-                <dependencies>
-                    <dependency>
-                        <groupId>com.puppycrawl.tools</groupId>
-                        <artifactId>checkstyle</artifactId>
-                        <version>${checkstyle.version}</version>
-                    </dependency>
-                </dependencies>
-                <executions>
-                    <execution>
-                        <goals>
-                            <goal>check</goal>
-                        </goals>
-                        <phase>validate</phase>
-                    </execution>
-                </executions>
-            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-enforcer-plugin</artifactId>