Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes in session manager #432

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Fixes in session manager #432

merged 5 commits into from
Jan 26, 2024

Conversation

merlimat
Copy link
Collaborator

There's an issue when the session manager is not reopening some of the sessions after restart.

  1. Because of the / suffix, the iterator was not picking the correct list in some cases
  2. The session manager needs to be initialized only after all the wal changes are applied to the db

@merlimat merlimat self-assigned this Jan 24, 2024
@merlimat merlimat merged commit 4f04a22 into streamnative:main Jan 26, 2024
4 checks passed
@merlimat merlimat deleted the fix-session-manager branch February 27, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattisonchao mattisonchao Awaiting requested review from mattisonchao mattisonchao is a code owner

@coderzc coderzc Awaiting requested review from coderzc coderzc is a code owner

@RobertIndie RobertIndie Awaiting requested review from RobertIndie RobertIndie is a code owner

Assignees

@merlimat merlimat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@merlimat