Remove un-subscription when closing consumer #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tisonkun I understand that this can be a breaking change for some. Do we want to consider making a new function? |
tisonkun
approved these changes
Jun 1, 2023
I remember that @DonghunLouisLee proposed #224 for version control. I feel somehow this lib is still under development before calling it a formal semantic version - We call for 5.0 at a small configuration update #240. But in another way, big version number doesn't mean a bad thing (IIRC arrow-rs arrives v40+ already). So my preference now is - release a 6.0.0 for this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove 'unsubscribe' from
consumer.close()#279