split out escalators from AddStepsIncline quest to allow different quest wording

[andrewharvey]

At present the AddStepsIncline quest applies to both steps and escalators, however the quest wording only mentions steps. This can lead to confusion.

For example https://www.openstreetmap.org/way/1241003118 was tagged highway=steps + conveying=yes to indicate it is an escalator, however the user was then asked "Which direction leads upwards for these steps?" to which they answered via the note https://www.openstreetmap.org/note/4351347 "Not steps, escalator".

By creating a new quest we can present the wording "Which direction leads upwards for these escalators?" to reduce confusion, and also help catch mistaggings of conveying=yes/no.

#3652 requested the ability to convert between the two, but that's a different issue and this change can be applied even without giving an opportunity to answer "these are escalators" / "these are steps".

[Helium314]

By creating a new quest we can present the wording "Which direction leads upwards for these escalators?"

Why not just edit getTitle(tags: Map<String, String>) in the normal incline quest?

[andrewharvey]

1. Because I couldn't find that being done in any of other quests code I looked at and wanted to try and retain the code style.
2. I don't actually know how to do it like that

[FloEdelmann]

An example can seen in

StreetComplete/app/src/main/java/de/westnordost/streetcomplete/quests/general_fee/AddGeneralFee.kt

Lines 28 to 33 in 6fd88eb

	override fun getTitle(tags: Map<String, String>) =
	if (tags["amenity"] == "sanitary_dump_station") {
	R.string.quest_generalFee_title
	} else {
	R.string.quest_generalFee_title2
	}

Other examples (for reference)

in no particular order:

• StreetComplete/app/src/main/java/de/westnordost/streetcomplete/quests/max_height/AddMaxPhysicalHeight.kt

  Lines 58 to 69 in 6fd88eb

  	override fun getTitle(tags: Map<String, String>): Int {
  	val isBelowBridge = tags["amenity"] != "parking_entrance"
  	&& tags["barrier"] != "height_restrictor"
  	&& tags["tunnel"] == null
  	&& tags["covered"] == null
  	&& tags["man_made"] != "pipeline"
  	// only the "below the bridge" situation may need some context
  	return when {
  	isBelowBridge -> R.string.quest_maxheight_below_bridge_title
  	else -> R.string.quest_maxheight_title
  	}
  	}

• StreetComplete/app/src/main/java/de/westnordost/streetcomplete/quests/barrier_opening/AddBarrierOpening.kt

  Lines 48 to 53 in 6fd88eb

  	override fun getTitle(tags: Map<String, String>) =
  	if (tags["barrier"] == "bollard" || tags["barrier"] == "block" || tags["cycle_barrier"] == "diagonal") {
  	R.string.quest_barrier_opening_width_bollard
  	} else {
  	R.string.quest_barrier_opening_width_gate
  	}

• StreetComplete/app/src/main/java/de/westnordost/streetcomplete/quests/building_levels/AddBuildingLevels.kt

  Lines 33 to 36 in 6fd88eb

  	override fun getTitle(tags: Map<String, String>) = when {
  	tags.containsKey("building:part") -> R.string.quest_buildingLevels_title_buildingPart2
  	else -> R.string.quest_buildingLevels_title2
  	}

• StreetComplete/app/src/main/java/de/westnordost/streetcomplete/quests/construction/MarkCompletedHighwayConstruction.kt

  Lines 25 to 41 in 6fd88eb

  	override fun getTitle(tags: Map<String, String>): Int {
  	val isRoad = ALL_ROADS.contains(tags["construction"])
  	val isCycleway = tags["construction"] == "cycleway"
  	val isFootway = tags["construction"] == "footway"
  	val isSteps = tags["construction"] == "steps"
  	/* Alternative could be "Is this construction finished?" and just display the feature name
  	* (e.g. "cycleway under construction") of the element above, but there are no iD presets
  	* for "highway=construction + construction=*" so such road would just be named
  	* "Road closed". Hence, keeping this (for now). */
  	return when {
  	isRoad -> R.string.quest_construction_road_title
  	isCycleway -> R.string.quest_construction_cycleway_title
  	isFootway -> R.string.quest_construction_footway_title
  	isSteps -> R.string.quest_construction_steps_title
  	else -> R.string.quest_construction_generic_title
  	}
  	}

• StreetComplete/app/src/main/java/de/westnordost/streetcomplete/quests/opening_hours/AddOpeningHours.kt

  Lines 132 to 141 in 6fd88eb

  	override fun getTitle(tags: Map<String, String>): Int {
  	// treat invalid opening hours like it is not set at all
  	val oh = tags["opening_hours"]?.toOpeningHoursOrNull(lenient = true)
  	val hasSupportedOpeningHours = oh != null && oh.isSupportedOpeningHours()
  	return if (hasSupportedOpeningHours) {
  	R.string.quest_openingHours_resurvey_title
  	} else {
  	R.string.quest_openingHours_title
  	}
  	}

[andrewharvey]

Thanks @FloEdelmann I obviously didn't check enough other quests! I can try to make the adjustment to use that style, assuming that the idea behind this PR is considered accetable?

[FloEdelmann]

Yeah, I guess the wording change makes sense. However, maybe we can just rename "Which direction leads upwards for these steps?" to "Which direction leads upwards here?"? Does the name label below the question already mention "Stairs" or "Escalator"?

[riQQ]

Does the name label below the question already mention "Stairs" or "Escalator"?

Yes

[andrewharvey]

Yeah, I guess the wording change makes sense. However, maybe we can just rename "Which direction leads upwards for these steps?" to "Which direction leads upwards here?"? Does the name label below the question already mention "Stairs" or "Escalator"?

I prefer to have "Steps/Stairs" and "Escalators" included in the quest title as it helps validate the data and catch any potentially mistagings. It also helps the quest mapper, user (quester? not sure what you call us solvers?) as you are more clear about exactly what the "direction leads up" is referring to.

[andrewharvey]

I've refactored to use a single quest but just varying the title. I haven't tested this yet.

[westnordost]

Actually, when I introduced the name label, I did that to reduce the text. Because the less text the better (as long as it remains clear). So, in general I concur with @FloEdelmann , it would be better if the wording was changed to "Which direction leads upwards here?". This then would also cover other things with an incline, such as ramps.

However, currently escalators are not labeled correctly in StreetComplete, they are labeled "steps". This is because the iD preset for escalators include a "*" value and osmfeatures, the library used to find the label for each feature, doesn't support this currently.

It's just a missing feature though, it would just need to be implemented.

When "escalator" was mentioned in the title, there'd be a mismatch with the displayed label (-> user is confused, thinks this is a bug, or wrong data), so this would be blocked by the linked issue.

However, you can apply @FloEdelmann's suggestion in any case, this is not blocked. (It should be a new key, like quest_incline_title).

[westnordost]

(see above)

[andrewharvey]

Actually, when I introduced the name label, I did that to reduce the text. Because the less text the better (as long as it remains clear). So, in general I concur with @FloEdelmann , it would be better if the wording was changed to "Which direction leads upwards here?". This then would also cover other things with an incline, such as ramps.

Ah that makes sense, I can see you do this already for other quests like "What is the surface here?".

[westnordost]

westnordost/osmfeatures#28

[goldfndr]

Might specify "this escalator" instead of "these escalators" for the string, as more than one escalator seems unlikely to be tagged as a single object. [If they are, they're possibly perceived as a single mechanism (interconnected motors), although that doesn't seem safe (consider LOTO).]

[westnordost]

Alright, so the mentioning of the escalator in the label is implemented in PR #6140. It was even much more work than I expected 😅

Would you make the change I requested?

[andrewharvey]

Sorry I'm confused, if the label is fixed to display "escalator" then we don't need this PR, we can just change quest_steps_incline_title from "Which direction leads upwards for these steps?" to "Which direction leads upwards here?"

Changeset comment can probably stay the same.

[FloEdelmann]

we can just change quest_steps_incline_title from "Which direction leads upwards for these steps?" to "Which direction leads upwards here?"

Exactly. You could adjust this PR to exactly this change (instead of adding another string and conditionally using that) if you want, so it can be merged. Otherwise, feel free to close it and someone else (e.g. me) could do that change instead, linking to this PR for reference.

[andrewharvey]

ok done, much simpler now.