support presets with "*" values

[westnordost]

using de.westnordost:osmfeatures:7.0

Might

• fix Ignore conveying way or steps in the surface overlay. #5728
• fix icons of vacant shops are sometimes wrong #4607
• fix don't show club=yes and unknown club values as "Other kind of place"  #6085
• unblock split out escalators from AddStepsIncline quest to allow different quest wording #6135

Helping with testing this would be appreciated. This is a change into some really (over-*)complex parts of StreetComplete, so quite a potential for issues.

---

* but necessarily so

[HolgerJeromin]

If you create a debug build some will test it for sure :-)

[westnordost]

After reading through the PR, at least these things should be tested:

• dialog that appears when selecting "it doesn't exist anymore" functions correctly for shops, amenities, ...: when selecting a generic feature (like "club"), when selecting that it's vacant
• "shop still vacant?" quest functions correctly (with some real data)
• "which shop type is this" quest functions correctly (with some real data, testing both answers)
• things overlay: disused POIs are displayed/handled correctly
• things overlay: adding POIs works correctly, including when selecting a generic feature (requires adding traffic_sign=* to the list of "Things" temporarily)
• places overlay: disused POIs are displayed/handled correctly
• places overlay: marking a POI as vacant will change tags to disused:*=*, marking a newly created POI as vacant will add shop=vacant instead

---

then, test if the issues above are solved now:

• escalators are labeled as such in quests and overlays (Ignore conveying way or steps in the surface overlay. #5728)
• clubs are displayed correctly and are selectable in the places overlay (don't show club=yes and unknown club values as "Other kind of place"  #6085)
• disused:shop + indoor=room (or building=*) should show shop icon, not indoor room/building icon (icons of vacant shops are sometimes wrong #4607)

---

• vacant shop icon should be the same on the map and in the selection screen(s)

[westnordost]

Here's a debug APK:

https://github.com/streetcomplete/StreetComplete/actions/runs/13485459314

(Don't ask me why it is packed in a zip. Is this normal, @FloEdelmann ?)

[HolgerJeromin]

(Don't ask me why it is packed in a zip. Is this normal, @FloEdelmann ?)

yes it is and this really is cumbersome.

https://github.com/actions/upload-artifact?tab=readme-ov-file#zip-archives

When an Artifact is uploaded, all the files are assembled into an immutable Zip archive. There is currently no way to download artifacts in a format other than a Zip or to download individual artifact contents.

[HolgerJeromin]

conveying=forward
highway=steps

https://www.openstreetmap.org/way/230302914
is shown in lit-overlay as "auf Ebene -1;0: Treppe"

[westnordost]

Thanks! Odd, I tested it with some other escalator and it said "escalator". I will check with the linked way.

[westnordost]

For me, the same way shows as "auf Ebene -1; 0: Rolltreppe"

[HolgerJeromin]

For me, the same way shows as "auf Ebene -1; 0: Rolltreppe"

My about screen showed v58.2. I think my upgrade of the apk did not succeeded...
deinstall, reinstall and now I have the same.
Sorry for the noise

[westnordost]

Alright, I tested everything listed. The boxes unchecked will not be done (though, the second checkbox would be solved with openstreetmap/id-tagging-schema#1457 ).

Would anyone review and/or test it?

[mnalis]

Would anyone review and/or test it?

I've been playing a little with provided debug APK, and I've noticed vacant icon problem (not the unchecked "vacant shop icon should be the same on the map and in the selection screen(s)" problem though, but maybe related):

• disused shops (e.g. disused:shop=clothes) have nice understandable icon (crossed-over-shop), but disused amenities (e.g. disused:amenity=cafe) have generic (i.e. "working") shopping-bag icon. e.g.
  

I would've expected that both disused:* icons look the same (or if different, that both have some kind of crossed-over icon indicating they are disused).

But perhaps that would be solved automagically with openstreetmap/id-tagging-schema#1457 (even if that is about shop=vacant and not about disused:*=* but it seems there is some cross-referencing between them - but too complex for me to grasp) ?

[mnalis]

I've also noticed that in shop overlay I can click on that disused:amenity=cafe (whose icon does not look like disused, nor like cafe, as shown above), and in three-dots menu I can still choose It's vacant, which seems to add additional shop=vacant tag to it.

While one perhaps shouldn't chose that option in normal usage (well, I wouldn't, but I was misled by the wrong icon) it seems like undesirable behaviour to me 🤷

[westnordost]

That's - both - odd, will have a look, thanks!