Skip to content

feat(examples,metrics,kube-state-metrics): extend configmap for 'KafkaConnect', 'KafkaConnector' and 'KafkaMirrorMaker2' #11354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(examples,metrics,kube-state-metrics): extend configmap for 'KafkaConnect', 'KafkaConnector' and 'KafkaMirrorMaker2' #11354

wants to merge 4 commits into from

Conversation

sebastiangaiser
Copy link
Contributor

Part of #10276

Type of change

Select the type of your PR

  • Enhancement / new feature

Description

Please check the commit messages

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@sebastiangaiser
fix(examples,metrics,ksm): add missing resources to 'ClusterRole'
f62e0e3 
This is part of implementing https://github.com/strimzi/proposals/blob/main/087-monitoring-of-custom-resources.md

Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com>
@sebastiangaiser
feat(examples,metrics,kube-state-metrics): extend configmap for 'Kafk…
3fb7108 
…aConnect', 'KafkaConnector' and 'KafkaMirrorMaker2'

In order to implement https://github.com/strimzi/proposals/blob/main/087-monitoring-of-custom-resources.md the configmap is extended for 'KafkaConnect', 'KafkaConnector' and 'KafkaMirrorMaker2' resources.

Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com>
@sebastiangaiser
feat(examples,metrics,ksm): add PrometheusRule for 'KafkaConnect', 'K…
9527ca9 
…afkaConnector' and 'KafkaMirrorMaker2'

Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com>
@ppatierno ppatierno added this to the 0.47.0 milestone Apr 22, 2025
ppatierno
ppatierno requested changes May 5, 2025
View reviewed changes
@ppatierno ppatierno requested review from a team and katheris May 5, 2025 15:08
@sebastiangaiser @ppatierno
Apply suggestions from code review
2f6d6d4 
Co-authored-by: Paolo Patierno <paolo.patierno@gmail.com>
Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com>
@sebastiangaiser
Copy link
Contributor Author

sebastiangaiser commented May 13, 2025 •
edited
Loading

Thanks for the review. I simply applied your suggestions 🚀

@sebastiangaiser sebastiangaiser requested a review from ppatierno May 13, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katheris katheris Awaiting requested review from katheris

@ppatierno ppatierno Awaiting requested review from ppatierno

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.47.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastiangaiser @ppatierno