Updates to build-emscripten script #1224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n.sh Currently when running the build-emscripten.sh script from another directory (as the script suggests) the base path for libde265 set in $LIBARY_LINKER_FLAGS and $LIBRARY_INCLUDE_FLAGS for get set to (if the src dir of the project is / and the build dir is /buildjs) /libde265-1.0.12 instead of /buildjs/libde265-1.0.12. This causes the compiler to fail to find libde265. This isn't caught in ./scripts/run-ci.sh because the script (on line 246) has "source ./emscripten/emsdk/emsdk_env.sh && USE_WASM=0 ./build-emscripten.sh ." using the same directory as both the source directory and the build directory. make the same fixes for aom
The --memory-init-file emcc flag was removed in version 3.1.55 so it has to be removed. Another emscripten option to generate typescript definitions was also added so this is added to the build-emscripten script.
|
Thank you! |
|
Thank you! Would you be able to provide release assets with dynamic execution disabled? I'll be happy to test and provide some validation in that ongoing thread. Would be amazing if we could update the HTML/web-based demo with this |
|
@farindk see new flag in this updated build script here including USE_UNSAFE_EVAL param. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues related to the
build-emscripten.shscript and adds some more options. Specifically:I chose to enable the generation of typescript definitions by default (for non-standalone builds) to make the library be more user-friendly for JS users so that they don't need to do as much digging into the libheif source code to figure out things like what functions are exported in the module and function signatures.