Support versions of libsdl2-dev before 2.0.18 #1516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't Ubuntu 20.04 EOL anyways? |
Standard-Support ends this May 31, but there might still be systems that have no upgraded yet or that use extended support until 2030 (and we provide packages starting with 20.04 in the PPA). Also it's a trivial fix ;-) If you don't want to support SDL2 < 2.0.18, please update the checks in cmake so the incompatibility is already detected earlier and not just through a compile error. |
|
No problem, just wanted to ask. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDL_GetTicks64 was introduced in SDL 2.0.18 but Ubuntu 20.04 still ships 2.0.10