Add test for tutorial notebooks #827
NimaSarajpoor
started this conversation in
General
Replies: 1 comment 2 replies
-
@NimaSarajpoor Perhaps, we can add the tests as you've proposed but, instead of running it here (and competing for the same CI resources), we can execute the test in the There, we can add a new workflow that gets triggered whenever there is a new commit or new PR and it can check tutorials.
Yes, that was on purpose and it is expected to be slow |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I was wondering if we could add a test for tutorial notebooks. Even if we do not put them in the CI flow, we may still get beenfit from this test as developers can run it locally and see if their changes result in any issue in the tutorial notebooks. This can become important if commits change code in
core.py
orstump.py
, which may affect more than one notebook.Can we do something like this: https://github.com/TDAmeritrade/stumpy/pull/826/files ? It is not complete as we need to remove some of the generated files (or maybe use an option to do that) and we need to continue testing notebooks even if one of them fails rather than being stopped at the first occurance of an error.
Also:
It seems that the following notebooks cannot be run successfully:
In addtion, the notebook
docs/Tutorial_Matrix_Profiles_For_Streaming_Data.ipynb
takes too much time. Maybe this is because my hardware is old (I am using a 10-year old pc, with 2 cores!) So, it would be great if it can be run on a newer device. If the running time issue persists, then I guess the reason is probably because of the fact that the existing version computes the sliding mean / std in a non-welford manner which is slower than welford approach.Note: In one of the cells, we run
stumpy.stump
several times (approx.10,000
iterations) as we updateT
, and the purpose is to show how its running time is compared to the performance ofstumpy/stumpi.py
.Beta Was this translation helpful? Give feedback.
All reactions