Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NEMO_RANS solver to the FluidProblem list #2193

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

ArasDogg
Copy link

@ArasDogg ArasDogg commented Jan 2, 2024

Proposed Changes

the GetFluidProblem() function was returning false for the NEMO_RANS solver. And therefore the CFD_ADAPT feature could not be used with the NEMO_RANS solver

Related Work

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • [X ] I am submitting my contribution to the develop branch.
  • [X ] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • [X ] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

the GetFluidProblem() function was returning false for the NEMO_RANS solver. And therefore the CFD_ADAPT feature could not be used with the NEMO_RANS solver
@mliza mliza merged commit 280488b into su2code:feature_nemoRANS_updated Jan 10, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants