Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output names of unsteady simulation #2418

Merged
merged 8 commits into from
Jan 24, 2025
Merged

Fix output names of unsteady simulation #2418

merged 8 commits into from
Jan 24, 2025

Conversation

rois1995
Copy link
Contributor

Proposed Changes

It solves two main issues in unsteady simulations:
1- if the history file is not updated during the simulation (ex. setting inner_iter = 0) the time iteration is not updated in the file output names.
2- mesh file output does not have the time iteration at the end.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@rois1995
Copy link
Contributor Author

I would also try to add the writing of the mesh in the CGNS format, although this can be done in another PR.

@bigfooted
Copy link
Contributor

LGTM

@pcarruscag pcarruscag merged commit 1f449b2 into develop Jan 24, 2025
35 checks passed
@pcarruscag pcarruscag deleted the fix_UnstNames branch January 24, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants