Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the use of conductivity models different from CONSTANT_PRANDTL for compressible flows. #2420

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

Cristopher-Morales
Copy link
Contributor

Proposed Changes

Enable the use other conductivity models for compressible flow. Updating thermal conductivity which has the turbulence contribution from MakeThermalConductivityModel function in CFluidModel.cpp.

Related Work

This is the first of small pull requests that are needed for enable FLUID_MIXTURE model for compressible flows.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@Cristopher-Morales Cristopher-Morales changed the title [WIP] Enable the use of conductivity models different from CONSTANT_PRANDTL for compressible flows. Enable the use of conductivity models different from CONSTANT_PRANDTL for compressible flows. Feb 20, 2025
Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 35 occurrences of GetPrandtl_Lam in 26 files, from the number of changes in this PR and number of cases updated I think you are missing a lot.

@@ -1660,8 +1658,7 @@ void CAdjNSSolver::BC_Isothermal_Wall(CGeometry *geometry, CSolver **solver_cont
GradT = solver_container[FLOW_SOL]->GetNodes()->GetGradient_Primitive(iPoint)[0];
kGTdotn = 0.0;
for (iDim = 0; iDim < nDim; iDim++)
kGTdotn += Cp * Laminar_Viscosity/Prandtl_Lam*GradT[iDim]*Normal[iDim]/Area;
// Cp * Viscosity/Prandtl_Lam matches term used in solver_direct_mean
kGTdotn += (Thermal_Conductivity - Cp * Eddy_Viscosity/Prandtl_Turb) * GradT[iDim]*Normal[iDim]/Area;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minus?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants