-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the use of conductivity models different from CONSTANT_PRANDTL for compressible flows. #2420
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see 35 occurrences of GetPrandtl_Lam in 26 files, from the number of changes in this PR and number of cases updated I think you are missing a lot.
@@ -1660,8 +1658,7 @@ void CAdjNSSolver::BC_Isothermal_Wall(CGeometry *geometry, CSolver **solver_cont | |||
GradT = solver_container[FLOW_SOL]->GetNodes()->GetGradient_Primitive(iPoint)[0]; | |||
kGTdotn = 0.0; | |||
for (iDim = 0; iDim < nDim; iDim++) | |||
kGTdotn += Cp * Laminar_Viscosity/Prandtl_Lam*GradT[iDim]*Normal[iDim]/Area; | |||
// Cp * Viscosity/Prandtl_Lam matches term used in solver_direct_mean | |||
kGTdotn += (Thermal_Conductivity - Cp * Eddy_Viscosity/Prandtl_Turb) * GradT[iDim]*Normal[iDim]/Area; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minus?
Proposed Changes
Enable the use other conductivity models for compressible flow. Updating thermal conductivity which has the turbulence contribution from MakeThermalConductivityModel function in CFluidModel.cpp.
Related Work
This is the first of small pull requests that are needed for enable FLUID_MIXTURE model for compressible flows.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --all
to format old commits.