-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] adding heat capacity and thermal conductivity as outputs for compressible #2421
base: develop
Are you sure you want to change the base?
Conversation
AddVolumeOutput("THERMAL_CONDUCTIVITY", "Thermal_Conductivity", "PRIMITIVE", "Thermal conductivity"); | ||
AddVolumeOutput("HEAT_CAPACITY", "Heat_Capacity", "PRIMITIVE", "Heat Capacity"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put them in a new group for now please.
AddVolumeOutput("THERMAL_CONDUCTIVITY", "Thermal_Conductivity", "FLUID_PROPERTIES", "Thermal conductivity"); | ||
AddVolumeOutput("HEAT_CAPACITY", "Heat_Capacity", "FLUID_PROPERTIES", "Heat Capacity"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add these after all the primitives were added. For solution that is a requirement otherwise we have issues with restarts. For primitives I don't think so but it would still be good to keep the convention.
@Cristopher-Morales would this also include thermal conductivity added surface outputs? This would help with issues such as #2438 |
Proposed Changes
Adding heat capacity and thermal conductivity as outputs for the compressible solver in order to help the process of debugging inside SU2.
Related Work
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --all
to format old commits.