Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] adding heat capacity and thermal conductivity as outputs for compressible #2421

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

Cristopher-Morales
Copy link
Contributor

Proposed Changes

Adding heat capacity and thermal conductivity as outputs for the compressible solver in order to help the process of debugging inside SU2.

Related Work

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • [X ] I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Comment on lines 257 to 258
AddVolumeOutput("THERMAL_CONDUCTIVITY", "Thermal_Conductivity", "PRIMITIVE", "Thermal conductivity");
AddVolumeOutput("HEAT_CAPACITY", "Heat_Capacity", "PRIMITIVE", "Heat Capacity");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put them in a new group for now please.

@Cristopher-Morales Cristopher-Morales changed the title adding heat capacity and thermal conductivity as outputs for compressible [WIP] adding heat capacity and thermal conductivity as outputs for compressible Jan 17, 2025
Comment on lines 257 to 258
AddVolumeOutput("THERMAL_CONDUCTIVITY", "Thermal_Conductivity", "FLUID_PROPERTIES", "Thermal conductivity");
AddVolumeOutput("HEAT_CAPACITY", "Heat_Capacity", "FLUID_PROPERTIES", "Heat Capacity");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add these after all the primitives were added. For solution that is a requirement otherwise we have issues with restarts. For primitives I don't think so but it would still be good to keep the convention.

@Hanquist
Copy link

@Cristopher-Morales would this also include thermal conductivity added surface outputs? This would help with issues such as #2438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants