-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error message when reference area is incorrect #2454
base: develop
Are you sure you want to change the base?
Conversation
if (TotalPositiveZArea <= 0.0) { | ||
SU2_MPI::Error( | ||
"ERROR: Total positive Z area is zero or negative! Please check the geometry and ensure the area is valid.", | ||
"CPhysicalGeometry::SetPositive_ZArea"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"CPhysicalGeometry::SetPositive_ZArea"); | |
CURRENT_FUNCTION); |
if (TotalPositiveYArea <= 0.0) { | ||
SU2_MPI::Error( | ||
"ERROR: Total positive Y area is zero or negative! Please check the geometry and ensure the area is valid.", | ||
"CPhysicalGeometry::SetPositive_ZArea"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here too
please check also why the regression tests are failing, they are all mms cases (method of manufactured solutions) which do not use this reference area at all afaik. |
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
Modified the conditional statements to trigger an error message when the projected area along the Z-axis is zero, indicating an incorrect refArea. Users are advised to check the geometry.
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --all
to format old commits.