Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message when reference area is incorrect #2454

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

vkrm1612
Copy link

@vkrm1612 vkrm1612 commented Feb 26, 2025

Proposed Changes

Give a brief overview of your contribution here in a few sentences.

Modified the conditional statements to trigger an error message when the projected area along the Z-axis is zero, indicating an incorrect refArea. Users are advised to check the geometry.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted bigfooted changed the title Issue 2435 Error message when reference area is incorrect Feb 26, 2025
if (TotalPositiveZArea <= 0.0) {
SU2_MPI::Error(
"ERROR: Total positive Z area is zero or negative! Please check the geometry and ensure the area is valid.",
"CPhysicalGeometry::SetPositive_ZArea");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"CPhysicalGeometry::SetPositive_ZArea");
CURRENT_FUNCTION);

if (TotalPositiveYArea <= 0.0) {
SU2_MPI::Error(
"ERROR: Total positive Y area is zero or negative! Please check the geometry and ensure the area is valid.",
"CPhysicalGeometry::SetPositive_ZArea");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here too

@bigfooted
Copy link
Contributor

please check also why the regression tests are failing, they are all mms cases (method of manufactured solutions) which do not use this reference area at all afaik.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants