Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add music facts on the loading screen #4336

Open
3 tasks done
arjunjayan999 opened this issue Feb 2, 2025 · 6 comments
Open
3 tasks done

Feature Request: Add music facts on the loading screen #4336

arjunjayan999 opened this issue Feb 2, 2025 · 6 comments

Comments

@arjunjayan999
Copy link
Contributor

Current Behavior

The loading screen currently displays arbitrary information about the loading process.

Desired Behavior

It would improve the user experience if the loading screen showed random music facts whenever the loading takes longer than expected.

Screenshots / Mockups

Previous Loading Screen

Original.Loading.Screen.mp4

After Implementation of Feature

Mockup.mp4

Implementation

Developers can add new fun music facts to the texts array in index.html. The random fact generator has already been implemented to choose a random fact each time.

Environment

  • Operating System: [e.g., Windows, macOS, Linux]
  • Browser (if applicable): [e.g., Chrome, Firefox, Safari]
  • Version of Software/Project: [e.g., v1.0.0]

Additional Information

I have already worked on this. This will be my first contribution, so I wanted to know if it is okay to raise a PR or should I wait for an approval.

Checklist

  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I am willing to contribute to resolving this issue.
@anya-xcode
Copy link

@pikurasa ,@quozl ,@walterbender
should we work on this issue or not?

@arjunjayan999
Copy link
Contributor Author

@anya-xcode I have already implemented this (there wasn't much work). Only question I have is it even wanted or they want ot keep the old loading. I am not raising a PR as of now since it is a design choice

@walterbender
Copy link
Member

Kind of cute... but an additional burden for our translators. not sure it is worth it. @pikurasa ?

@pikurasa
Copy link
Collaborator

pikurasa commented Feb 4, 2025

Kind of cute... but an additional burden for our translators. not sure it is worth it. @pikurasa ?

Perhaps only if there is some sort of external, well-maintained repository of facts and translations...

But, that said, this is not a priority. In fact, we're actively trying to reduce the load time, which will mean fewer facts to display.

A few of these facts could be made into Music Blocks projects themselves and shared to the Planet (when the Planet is live again).

@arjunjayan999
Copy link
Contributor Author

arjunjayan999 commented Feb 5, 2025

Kind of cute... but an additional burden for our translators. not sure it is worth it. @pikurasa ?

Perhaps only if there is some sort of external, well-maintained repository of facts and translations...

But, that said, this is not a priority. In fact, we're actively trying to reduce the load time, which will mean fewer facts to display.

A few of these facts could be made into Music Blocks projects themselves and shared to the Planet (when the Planet is live again).

@pikurasa If you get rid of the loading screen all together then yes this is obsolete. But showing a random fact each time the loading screen pops up (even if one or two), it will add to user experience I think. It can also be about the functionalities of MB like "Did you know you can download your projects and share them with the world in Music Blocks!". This way they can be prompted to explore these functions.
On the side note, I actually have faced issue with getting stuck in loading screen (it is probably something related to cache since a hard refresh makes it work again, there is console log of errors about target bpm not being defined, then others),

@pikurasa
Copy link
Collaborator

pikurasa commented Feb 5, 2025

@pikurasa If you get rid of the loading screen all together then yes this is obsolete. But showing a random fact each time the loading screen pops up (even if one or two), it will add to user experience I think. It can also be about the functionalities of MB like "Did you know you can download your projects and share them with the world in Music Blocks!". This way they can be prompted to explore these functions.

Yes, but it still isn't a high priority at the moment.

On the side note, I actually have faced issue with getting stuck in loading screen (it is probably something related to cache since a hard refresh makes it work again, there is console log of errors about target bpm not being defined, then others),

Yes, we are aware of this issue and are working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants