Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow for the running tests #4408

Merged
merged 7 commits into from
Feb 16, 2025
Merged

Conversation

omsuneri
Copy link
Member

@omsuneri omsuneri commented Feb 14, 2025

@walterbender I had created a github workflow for running jest test suites whenever a PR is raised please review this
also this workflow creates a comment on the PR about the test result with the log of failed test suites
which the author need to take note of after raising a PR.
Screenshot 2025-02-14 at 4 27 27 PM

@omsuneri
Copy link
Member Author

@walterbender what i found is that the test is runing beautifully on my fork and here too but the only thing here we dont get is the comment on the PR which is i guess more important but i m trying to get the result done

@walterbender
Copy link
Member

Looks good.
Screenshot From 2025-02-14 13-32-52

@omsuneri
Copy link
Member Author

omsuneri commented Feb 14, 2025

@walterbender thanks !! i m working on the comment thing too but getting stuck somewhere with the github tokens can you can review the error in the workflow log i got that we need to add some secret PAT(personal access token in the workflow) which i m investigating will be get done soon
Screenshot 2025-02-15 at 12 09 48 AM

@walterbender
Copy link
Member

I think Ibiam may have recently dealt with PAT issues on GitHub. Maybe ask in the #sugar channel on Matrix?

@omsuneri
Copy link
Member Author

@walterbender I found that I need to have the write access over the musicblocks repo in order to add the PAT in secrets and variables for our actions can you please give me the rights to access the same
I need the setting access for the repo currently I m having member but that doesn't allows me to do changes in the secret and variables of action workflow

@chimosky
Copy link
Member

chimosky commented Feb 15, 2025

@walterbender what i found is that the test is runing beautifully on my fork and here too but the only thing here we dont get is the comment on the PR which is i guess more important but i m trying to get the result done

From the screenshot above, it looks like there's a comment on your fork, if that's the case then it works.

The reason you don't get a comment here is because this hasn't been merged.

If the workflow needs a particular secret, that's when we'll add it to this repo and point the workflow to that, else it'll work fine once this is merged.

@omsuneri
Copy link
Member Author

@chimosky as for ss I made two branches one on mb master and other with changes in workflow still that works as I don't merged the changes there too so think it must work here as it does there too

@omsuneri
Copy link
Member Author

@chimosky i get from your point that first we should merge this first then check if its working or not if not then need to add the secrets am i right ?

@omsuneri
Copy link
Member Author

omsuneri commented Feb 15, 2025

@walterbender I found a cache with this workflow as it is currently running test on the changes but we want that the test must be run on the merged changes like the workflow must assume that if the changes are merged then what might be the potential failures in the test so I redesign the test workflow and its working absolutely fine with my fork
updated in 187c04d

@omsuneri
Copy link
Member Author

@walterbender I request you to merge this as if it works expectedly after merging then fine and if not we can add Personal access tokens in the workflow for the comment part

@walterbender walterbender merged commit 53236b9 into sugarlabs:master Feb 16, 2025
4 of 5 checks passed
@walterbender
Copy link
Member

Let's keep an eye on this

@omsuneri
Copy link
Member Author

@walterbender sure will take a look over it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants