Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Preloading Fallback Font for slower connections #4415

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

arjunjayan999
Copy link
Contributor

This PR resolves issue #4413 and includes changes to improve the loading performance of web pages by preloading fonts.
On slower connections, the material-icons.woff2 font would be loaded later, so the font is preloaded, and is then fetched from disk cache now.

Before

Screen.Recording.2025-02-16.130630.mp4

After

Screen.Recording.2025-02-16.131220.mp4

Performance improvements:

  • index.html: Added a link tag to preload the material-icons.woff2 font.
  • planet/index.html: Added a link tag to preload the material-icons.woff2 font.

@walterbender
Copy link
Member

Works, except sometimes it doesn't?
Screenshot From 2025-02-16 07-20-56

@arjunjayan999
Copy link
Contributor Author

@walterbender Been trying to reproduce any issue, can't seem to find any. I have tried multiple times and different browsers, it seems to work fine. Any tips to reproduce this issue? and anything in the console log?

@walterbender
Copy link
Member

I will try to reproduce it.

@walterbender
Copy link
Member

I cannot reproduce the error.

@walterbender walterbender merged commit ee12481 into sugarlabs:master Feb 16, 2025
4 checks passed
@arjunjayan999 arjunjayan999 deleted the fix/material-icons branch February 17, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants