Skip to content

Commit 01fc989

Browse files
Isotr0pysumitd2
authored andcommitted
[Hardware][CPU] Enable mrope and support Qwen2-VL on CPU backend (vllm-project#8770)
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
1 parent 9bf6b07 commit 01fc989

File tree

2 files changed

+99
-9
lines changed

2 files changed

+99
-9
lines changed

vllm/model_executor/models/qwen2_vl.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@
6767
from vllm.platforms import current_platform
6868
from vllm.sequence import IntermediateTensors, SequenceData
6969
from vllm.transformers_utils.processor import get_processor
70+
from vllm.utils import is_cpu
7071

7172
from .utils import (PPMissingLayer, is_pp_missing_parameter,
7273
make_empty_intermediate_tensors_factory)
@@ -281,6 +282,21 @@ def forward(
281282
context_layer = rearrange(output,
282283
"(b s) ... -> b s ...",
283284
b=batch_size)
285+
elif is_cpu():
286+
seq_length = q.size(1)
287+
q, k, v = [rearrange(x, "b s h d -> b h s d") for x in [q, k, v]]
288+
attention_mask = torch.zeros([1, seq_length, seq_length],
289+
device=q.device,
290+
dtype=torch.bool)
291+
for i in range(1, len(cu_seqlens)):
292+
attention_mask[..., cu_seqlens[i - 1]:cu_seqlens[i],
293+
cu_seqlens[i - 1]:cu_seqlens[i]] = True
294+
output = F.scaled_dot_product_attention(q,
295+
k,
296+
v,
297+
attention_mask,
298+
dropout_p=0.0)
299+
context_layer = rearrange(output, "b h s d -> b s h d ")
284300
else:
285301
from xformers import ops as xops
286302
from xformers.ops.fmha.attn_bias import BlockDiagonalMask

vllm/worker/cpu_model_runner.py

Lines changed: 83 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,13 @@
1212
SchedulerConfig)
1313
from vllm.logger import init_logger
1414
from vllm.model_executor import SamplingMetadata
15+
from vllm.model_executor.layers.rotary_embedding import MRotaryEmbedding
1516
from vllm.model_executor.layers.sampler import SamplerOutput
1617
from vllm.model_executor.model_loader import get_model
1718
from vllm.multimodal import (MULTIMODAL_REGISTRY, BatchedTensorInputs,
1819
MultiModalInputs)
19-
from vllm.sequence import IntermediateTensors, SequenceGroupMetadata
20+
from vllm.sequence import (IntermediateTensors, SequenceData,
21+
SequenceGroupMetadata)
2022
from vllm.utils import STR_NOT_IMPL_ENC_DEC_ERR_STRS, make_tensor_with_pad
2123
from vllm.worker.model_runner_base import (
2224
ModelRunnerBase, ModelRunnerInputBase, ModelRunnerInputBuilderBase,
@@ -145,6 +147,38 @@ def build(self) -> ModelInputForCPU:
145147
query_lens=seq_lens,
146148
)
147149

150+
def _compute_multi_modal_input(self, seq_data: SequenceData, mm_data,
151+
computed_len: int):
152+
mm_kwargs = self.multi_modal_input_mapper(mm_data)
153+
154+
# special processing for mrope position deltas.
155+
mrope_positions = None
156+
if self.runner.model_is_mrope:
157+
image_grid_thw = mm_kwargs.get("image_grid_thw", None)
158+
video_grid_thw = mm_kwargs.get("video_grid_thw", None)
159+
assert image_grid_thw is not None or video_grid_thw is not None, (
160+
"mrope embedding type requires multi-modal input mapper "
161+
"returns 'image_grid_thw' or 'video_grid_thw'.")
162+
163+
hf_config = self.runner.model_config.hf_config
164+
token_ids = seq_data.get_token_ids()
165+
166+
mrope_positions, mrope_position_delta = \
167+
MRotaryEmbedding.get_input_positions(
168+
token_ids,
169+
image_grid_thw=image_grid_thw,
170+
video_grid_thw=video_grid_thw,
171+
image_token_id=hf_config.image_token_id,
172+
video_token_id=hf_config.video_token_id,
173+
vision_start_token_id=hf_config.vision_start_token_id,
174+
vision_end_token_id=hf_config.vision_end_token_id,
175+
spatial_merge_size=hf_config.vision_config.
176+
spatial_merge_size,
177+
context_len=computed_len,
178+
)
179+
seq_data.mrope_position_delta = mrope_position_delta
180+
return mm_kwargs, mrope_positions
181+
148182
def _prepare_prompt(
149183
self,
150184
seq_group_metadata_list: List[SequenceGroupMetadata],
@@ -153,6 +187,8 @@ def _prepare_prompt(
153187
assert len(seq_group_metadata_list) > 0
154188
input_tokens: List[int] = []
155189
input_positions: List[int] = []
190+
input_mrope_positions: List[List[int]] = [[] for _ in range(3)]
191+
156192
slot_mapping: List[int] = []
157193
seq_lens: List[int] = []
158194
multi_modal_inputs_list: List[MultiModalInputs] = []
@@ -171,14 +207,20 @@ def _prepare_prompt(
171207
seq_lens.append(seq_len) # Prompt token num
172208
input_tokens.extend(prompt_tokens) # Token ids
173209

210+
mrope_positions = None
211+
if (mm_data := seq_group_metadata.multi_modal_data):
212+
mm_kwargs, mrope_positions = self._compute_multi_modal_input(
213+
seq_data, mm_data, computed_len)
214+
multi_modal_inputs_list.append(mm_kwargs)
215+
174216
# Token position ids
175217
# NOTE(woosuk): Here we assume that the first token in the prompt
176218
# is always the first token in the sequence.
177-
input_positions.extend(list(range(computed_len, seq_len)))
178-
179-
if (mm_data := seq_group_metadata.multi_modal_data):
180-
mm_kwargs = self.multi_modal_input_mapper(mm_data)
181-
multi_modal_inputs_list.append(mm_kwargs)
219+
if mrope_positions:
220+
for idx in range(3):
221+
input_mrope_positions[idx].extend(mrope_positions[idx])
222+
else:
223+
input_positions.extend(list(range(computed_len, seq_len)))
182224

183225
# Compute the slot mapping.
184226
block_table = seq_group_metadata.block_tables[seq_id]
@@ -202,12 +244,18 @@ def _prepare_prompt(
202244
slot = block_number * self.block_size + block_offset
203245
slot_mapping.append(slot)
204246

247+
if any(input_mrope_positions):
248+
input_positions = None # type: ignore
249+
else:
250+
input_mrope_positions = None # type: ignore
251+
205252
num_prompt_tokens = len(input_tokens)
206253

207254
input_tokens = torch.tensor(input_tokens,
208255
dtype=torch.long,
209256
device=self.device) # type: ignore
210-
input_positions = torch.tensor(input_positions,
257+
input_positions = torch.tensor(input_positions
258+
or input_mrope_positions,
211259
dtype=torch.long,
212260
device=self.device) # type: ignore
213261
slot_mapping = torch.tensor(slot_mapping,
@@ -238,6 +286,7 @@ def _prepare_decode(
238286
assert len(seq_group_metadata_list) > 0
239287
input_tokens: List[int] = []
240288
input_positions: List[int] = []
289+
input_mrope_positions: List[List[int]] = [[] for _ in range(3)]
241290
slot_mapping: List[int] = []
242291
seq_lens: List[int] = []
243292
block_tables: List[List[int]] = []
@@ -255,7 +304,17 @@ def _prepare_decode(
255304

256305
seq_len = seq_data.get_len()
257306
position = seq_len - 1
258-
input_positions.append(position)
307+
if seq_data.mrope_position_delta is not None:
308+
context_len = seq_data.get_num_computed_tokens()
309+
next_pos = MRotaryEmbedding.get_next_input_positions(
310+
seq_data.mrope_position_delta,
311+
context_len,
312+
seq_len,
313+
)
314+
for idx in range(3):
315+
input_mrope_positions[idx].extend(next_pos[idx])
316+
else:
317+
input_positions.append(position)
259318

260319
seq_len = seq_len if self.sliding_window is None else min(
261320
seq_len, self.sliding_window)
@@ -273,12 +332,18 @@ def _prepare_decode(
273332
block_table = block_table[-sliding_window_blocks:]
274333
block_tables.append(block_table)
275334

335+
if any(input_mrope_positions):
336+
input_positions = None # type: ignore
337+
else:
338+
input_mrope_positions = None # type: ignore
339+
276340
max_decode_seq_len = max(seq_lens)
277341

278342
input_tokens = torch.tensor(input_tokens,
279343
dtype=torch.long,
280344
device=self.device)
281-
input_positions = torch.tensor(input_positions,
345+
input_positions = torch.tensor(input_positions
346+
or input_mrope_positions,
282347
dtype=torch.long,
283348
device=self.device)
284349
slot_mapping = torch.tensor(slot_mapping,
@@ -373,6 +438,15 @@ def __init__(
373438
raise NotImplementedError(
374439
STR_NOT_IMPL_ENC_DEC_ERR_STRS['STR_NOT_IMPL_ENC_DEC_CPU'])
375440

441+
@property
442+
def model_is_mrope(self) -> bool:
443+
"""Detect if the model has "mrope" rope_scaling type.
444+
mrope requires keep "rope_deltas" between prompt and decoding phases."""
445+
rope_scaling = getattr(self.model_config.hf_config, "rope_scaling", {})
446+
if rope_scaling is None:
447+
return False
448+
return rope_scaling.get("type", None) == "mrope"
449+
376450
def load_model(self) -> None:
377451
self.model = get_model(model_config=self.model_config,
378452
load_config=self.load_config,

0 commit comments

Comments
 (0)