Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with 64 bit integers in CRT for Windows #181

Merged
merged 4 commits into from
Mar 17, 2025
Merged

Conversation

pogudingleb
Copy link
Collaborator

@pogudingleb pogudingleb commented Mar 15, 2025

Since long int is 32 bit on Windows, there was a problem in CRT for 64-bit numbers. The goal of this PR is to fix this.

Copy link

codecov bot commented Mar 15, 2025

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.30%. Comparing base (31c1be0) to head (393eac3).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/reconstruction/crt.jl 86.95% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
- Coverage   93.34%   93.30%   -0.04%     
==========================================
  Files          42       42              
  Lines        5856     5874      +18     
==========================================
+ Hits         5466     5481      +15     
- Misses        390      393       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sumiya11
Copy link
Owner

Thank you, Gleb !

@sumiya11 sumiya11 merged commit 0d94c8b into master Mar 17, 2025
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants