use arc for schema cache

Author: psteinroe

crates/pgt_workspace/src/workspace/server.rs

@@ -372,7 +372,7 @@ impl Workspace for WorkspaceServer {
         {
             let path_clone = params.path.clone();
             let schema_cache = self.schema_cache.load(pool.clone())?;
-            let schema_cache_arc = Arc::new(schema_cache.as_ref().clone());
+            let schema_cache_arc = schema_cache.get_arc();
             let input = parser.iter(AsyncDiagnosticsMapper).collect::<Vec<_>>();
             // sorry for the ugly code :(
             let async_results = run_async(async move {

crates/pgt_workspace/src/workspace/server/schema_cache_manager.rs

@@ -1,4 +1,4 @@
-use std::sync::{RwLock, RwLockReadGuard};
+use std::sync::{Arc, RwLock, RwLockReadGuard};
 
 use pgt_schema_cache::SchemaCache;
 use sqlx::PgPool;
@@ -21,6 +21,10 @@ impl<'a> SchemaCacheHandle<'a> {
     pub(crate) fn wrap(inner: RwLockReadGuard<'a, SchemaCacheManagerInner>) -> Self {
         Self { inner }
     }
+
+    pub fn get_arc(&self) -> Arc<SchemaCache> {
+        Arc::clone(&self.inner.cache)
+    }
 }
 
 impl AsRef<SchemaCache> for SchemaCacheHandle<'_> {
@@ -31,7 +35,7 @@ impl AsRef<SchemaCache> for SchemaCacheHandle<'_> {
 
 #[derive(Default)]
 pub(crate) struct SchemaCacheManagerInner {
-    cache: SchemaCache,
+    cache: Arc<SchemaCache>,
     conn_str: String,
 }
 
@@ -62,7 +66,7 @@ impl SchemaCacheManager {
 
             // Double-check that we still need to refresh (another thread might have done it)
             if new_conn_str != inner.conn_str {
-                inner.cache = refreshed;
+                inner.cache = Arc::new(refreshed);
                 inner.conn_str = new_conn_str;
                 tracing::info!("Refreshed connection.");
             }