straightened

Author: juleswritescode

crates/pglt_analyser/tests/specs/safety/addingRequiredField/basic.sql

@@ -1,2 +1,3 @@
 -- expect_only_lint/safety/addingRequiredField
--- select 1;
+alter table test
+add column c int not null;

crates/pglt_analyser/tests/specs/safety/addingRequiredField/basic.sql.snap

@@ -0,0 +1,17 @@
+---
+source: crates/pglt_analyser/tests/rules_tests.rs
+expression: snapshot
+---
+# Input
+```
+-- expect_only_lint/safety/addingRequiredField
+alter table test
+add column c int not null;
+```
+
+# Diagnostics
+lint/safety/addingRequiredField ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  × Adding a new column that is NOT NULL and has no default value to an existing table effectively makes it required.
+  
+  i Make new columns optional initially by omitting the NOT NULL constraint until all existing data and application code has been updated. Once no NULL values are written to or persisted in the database, set it to NOT NULL. Alternatively, if using Postgres version 11 or later, add a DEFAULT value that is not volatile. This allows the column to keep its NOT NULL constraint.

crates/pglt_analyser/tests/specs/safety/addingRequiredField/with_default.sql

@@ -0,0 +1,3 @@
+-- expect_no_diagnostics
+alter table test
+add column c int not null default 0;

crates/pglt_analyser/tests/specs/safety/addingRequiredField/with_default.sql.snap

@@ -0,0 +1,10 @@
+---
+source: crates/pglt_analyser/tests/rules_tests.rs
+expression: snapshot
+---
+# Input
+```
+-- expect_no_diagnostics
+alter table test
+add column c int not null default 0;
+```

crates/pglt_analyser/tests/specs/safety/addingRequiredField/without_required.sql

@@ -0,0 +1,3 @@
+-- expect_no_diagnostics
+alter table test
+add column c int;

crates/pglt_analyser/tests/specs/safety/addingRequiredField/without_required.sql.snap

@@ -0,0 +1,10 @@
+---
+source: crates/pglt_analyser/tests/rules_tests.rs
+expression: snapshot
+---
+# Input
+```
+-- expect_no_diagnostics
+alter table test
+add column c int;
+```