adds postgres version to the schema cache. #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteinroe
requested changes
Aug 27, 2024
| ) AS active_connections, | ||
| current_setting('max_connections') :: int8 AS max_connections;"# | ||
| ) | ||
| .fetch_all(pool) |
|
|
||
| #[derive(Debug, Clone, Default)] | ||
| pub struct SchemaCache { | ||
| pub schemas: Vec<Schema>, | ||
| pub tables: Vec<Table>, | ||
| pub functions: Vec<Function>, | ||
| pub types: Vec<PostgresType>, | ||
| pub versions: Vec<Version>, |
There was a problem hiding this comment.
any reason to have a Vec instead of a single struct?
|
Hey @psteinroe , thanks for the reply. While it does make sense to have a single type instead of a Vec, the pub trait SchemaCacheItem {
type Item;
async fn load(pool: &PgPool) -> Vec<Self::Item>;
}is defined as having a |
|
Ah yeah I think it makes sense to refactor this a bit. Do you want to do it in your pr or should we merge and do a follow-up? 🙏🏼 |
|
Let's do a follow up. I'm not sure how the refactoring will look like at the moment. |
|
sounds good! the ci is failing due to an unrelated issue. I am going to fix it soon and then merge 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the postgres version in the schema cache using SQL from the
pg-metalibrary.