Skip to content

Unnecessary and confusing use of _currentUser variable #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juampiq6 opened this issue May 7, 2025 · 0 comments
Open

Unnecessary and confusing use of _currentUser variable #1167

juampiq6 opened this issue May 7, 2025 · 0 comments

Comments

@juampiq6
Copy link

juampiq6 commented May 7, 2025

Hi team,
[context] -> gotrue package -> gotrue_client.dart

I found out that the_currentUser variable was being assigned as a copy of what _currentSession.user is already storing. I find it confusing for it to be a copied value when non needed. Unless I'm missing something, but I couldnt find other usages in the code.

I'm making a PR to solve this simple confusion.

Hope it helps.
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant