-
-
Notifications
You must be signed in to change notification settings - Fork 214
feat: Broadcast auth events to other tabs on web #1005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
04eab28
feat: broadcast auth events on web
Vinzent03 e372c46
refactor: consolidate types in one file
Vinzent03 4b400f0
fix: add dispose to auth client
Vinzent03 1bc9557
refactor: use js object for messaging
Vinzent03 16449e6
style: remove unused userDeleted event
Vinzent03 9963396
refactor: remove deprecation of supabasePersistSessionKey
Vinzent03 40c29e1
fix: store session in client
Vinzent03 8cb8735
fix: allow removing session on broadcast and add bool to AuthState
Vinzent03 cb4050f
fix: catch session being null
Vinzent03 c618526
fix: improvements from code review
Vinzent03 5b84d46
fix: remove broadcastSession from constructor
Vinzent03 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
import 'package:gotrue/src/types/types.dart'; | ||
|
||
/// Stub implementation of [BroadcastChannel] for platforms that don't support it. | ||
BroadcastChannel getBroadcastChannel(String broadcastKey) { | ||
throw UnimplementedError(); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import 'dart:convert'; | ||
import 'dart:html' as html; | ||
import 'dart:js_util' as js_util; | ||
|
||
import 'package:gotrue/src/types/types.dart'; | ||
|
||
BroadcastChannel getBroadcastChannel(String broadcastKey) { | ||
final broadcast = html.BroadcastChannel(broadcastKey); | ||
return ( | ||
onMessage: broadcast.onMessage.map((event) { | ||
final dataMap = js_util.dartify(event.data); | ||
|
||
// some parts have the wrong map type. This is an easy workaround and | ||
// should be efficient enough for the small session and user data | ||
return json.decode(json.encode(dataMap)); | ||
}), | ||
postMessage: (message) { | ||
final jsMessage = js_util.jsify(message); | ||
broadcast.postMessage(jsMessage); | ||
}, | ||
close: broadcast.close, | ||
); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
11 changes: 11 additions & 0 deletions
11
...gotrue/lib/src/types/o_auth_provider.dart → packages/gotrue/lib/src/types/types.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.