feat(supabase_flutter): Update app_links dependency to v6.0.1 #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this would be a breaking change on supabase_flutter for anyone using it with app_links, so we would wait until the next breaking change to introduce this update. Maybe we can explore handling deep links without app_links dependencies? https://docs.flutter.dev/ui/navigation/deep-linking |
|
Can't we try to call the old methods with a try catch, and fallback to the new one? Definitely isn't the best way, but it should work. |
|
@Vinzent03 I really don't think it's possible, but you have surprised me so many times in the past. Could you show me how that would work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
With app_links version 6.0.0 there are breaking changes in the app_links api (https://pub.dev/packages/app_links/changelog):
Breaking: Renamed getInitialApp* and getLatestApp* methods to getInitialLink* and getLatestLink*.I adjusted this in the PR and bumped the app_links package to ^6.0.1
Additional context
I don't know whether you directly want to bump the app_links version, as there were multiple breaking version releases in the last 2 months. Just wanted to make this small PR as I personally bumped the version for myself.