Skip to content

fix: Keep compatible with app_links 6.0.0 and 5.0.0 #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2024

Conversation

Vinzent03
Copy link
Collaborator

What kind of change does this PR introduce?

Bug fix, dependency version bump

What is the current behavior?

app_links 6.0.0 is not supported

What is the new behavior?

5.0.0 is still supported and 6.0.0 now as well, despite the breaking change, by trying both methods with error catching.
Additionally, the supabase_flutter packages is now tested with downgraded packages versions as well.

Additional context

#915 wanted to drop support for 5.0.0

@Vinzent03 Vinzent03 changed the title fix: keep compatible with app_links 6.0.0 and 5.0.0 fix: Keep compatible with app_links 6.0.0 and 5.0.0 May 6, 2024
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, casting it to dynamic! Nice trick! Thanks for this!

@dshukertjr dshukertjr merged commit 04a59dc into main May 7, 2024
3 checks passed
@dshukertjr dshukertjr deleted the chore/upgrade-app-links branch May 7, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants