Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More understandable sign message [discuss] #18

Open
shapkarin opened this issue Oct 9, 2020 · 3 comments
Open

More understandable sign message [discuss] #18

shapkarin opened this issue Oct 9, 2020 · 3 comments

Comments

@shapkarin
Copy link
Contributor

As I understand the main goal is to make messages as much understandable as it can me. We need to find some balance between technical description and understand for non tech users. Lets discuss that.

I suggest that message:

Login with Superhero account at ${new Date().toUTCString()}

But as @davidyuk mentioned that message is not about sign. So maybe we can find something between technical description and understand for non tech users.

ref: #17

@davidyuk
Copy link
Member

davidyuk commented Oct 9, 2020

Originally I was thinking about this as a service for the whole aeternity, so I don't like the connection to Superhero.

The generation of JWT token is not necessarily connected to logining into something, so would be more accurate to say "generate access token".

The message should be like "... generate access token ... at ".

@shapkarin
Copy link
Contributor Author

@davidyuk can you provide some use case when user can see that message without login but only sign?

@davidyuk
Copy link
Member

Currently, we are using signing to confirm every action on superhero-ui, we can use JWT tokens there and I think it won't be accurate to call it 'login'.

'login' term in comparison with 'access token' is more confusing because it omits the ability to share it with other services.

Probably would be more accurate to call it authenticate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants