Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use avatars consistent with superhero-ui/wallet instead of robohash.org #7

Open
davidyuk opened this issue Jul 24, 2020 · 5 comments
Open

Comments

@davidyuk
Copy link
Member

No description provided.

@mradkov
Copy link
Contributor

mradkov commented Jul 27, 2020

This should be closed by #12

@mradkov mradkov closed this as completed Jul 27, 2020
@davidyuk
Copy link
Member Author

But actually, there are two kinds of avatars, shouldn't we handle them both?

@davidyuk davidyuk reopened this Jul 28, 2020
@mradkov
Copy link
Contributor

mradkov commented Jul 28, 2020

But actually, there are two kinds of avatars, shouldn't we handle them both?

You mean the custom ones as well?

@davidyuk
Copy link
Member Author

I meant avatars generated by jdenticon: https://github.com/aeternity/superhero-ui/blob/5fff860514e10290cab555d2e0f35f23a732a740/src/components/Avatar.vue#L43-L55

But would be nice to support custom avatars as well.

@mradkov
Copy link
Contributor

mradkov commented Jul 28, 2020

Do we get the .chain name at the time of signing the jwt token - in that case, we can resolve this easily by falling back to the jdenticon if there is not .chain name for this account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants