-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix combineWithAllErrors types #483
Merged
supermacro
merged 7 commits into
supermacro:master
from
braxtonhall:fix-combine-with-all-errors
Aug 28, 2024
Merged
Fix combineWithAllErrors types #483
supermacro
merged 7 commits into
supermacro:master
from
braxtonhall:fix-combine-with-all-errors
Aug 28, 2024
+50
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@braxtonhall Hi, this PR looks nice. |
🦋 Changeset detectedLatest commit: ecc25b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
a05f03e
to
e66ac73
Compare
@m-shaka resolved! |
m-shaka
approved these changes
Aug 21, 2024
supermacro
approved these changes
Aug 28, 2024
This was referenced Aug 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combineWithAllErrors
provides types that are not necessarily correct.The documentation actually correctly matches the implementation, but the type declarations are a little off. In the types, if a literal array is provided, the
Result
s are given toTraverseWithAllErrors
which preserves the error order.