-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return ResultAsync<T, E> from safeTry instead of Promise<Result<T, E>> for better composability #562
Conversation
…> for better composability
🦋 Changeset detectedLatest commit: 16452c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Appears to be a fix for #561 |
@mattpocock
not sure if I understand it fully |
@sharno Agree. Neverthrow doesn't guarantee that a function will never throw. So this feels overly defensive on the library's part. |
@sharno looks good, but note that types need to be updated on some tests |
updated and fixed the tests 👍 |
No description provided.