Skip to content

Prettier and eslint improvements (no dependency upgrades yet) #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
a50bb55
Prettier and eslint improvements (no upgrades yet)
mattpocock Aug 20, 2024
cbdcd11
Made prettier run on everything
mattpocock Aug 20, 2024
09f869c
Ran prettier on rollup
mattpocock Aug 20, 2024
99f35a5
Ran prettier on typecheck tessts
mattpocock Aug 20, 2024
7727078
Formatted typecheck-tests
mattpocock Aug 20, 2024
670da07
Added cache for ESLint
mattpocock Sep 6, 2024
fb701ed
Prettier and eslint improvements (no upgrades yet)
mattpocock Aug 20, 2024
877b0a3
Made prettier run on everything
mattpocock Aug 20, 2024
d0ea4c5
Ran prettier on rollup
mattpocock Aug 20, 2024
3b76894
Ran prettier on typecheck tessts
mattpocock Aug 20, 2024
fe0186c
Added cache for ESLint
mattpocock Sep 6, 2024
721d1bb
Merge
mattpocock Sep 6, 2024
70431d6
Remove import type from typecheck tests
mattpocock Sep 6, 2024
d2e6e57
Merge branch 'master' into matt/prettier-and-eslint-improvements--no-…
supermacro Sep 6, 2024
12a9ae4
Fixed test
mattpocock Sep 6, 2024
d4b8d4d
Prettier and eslint improvements (no upgrades yet)
mattpocock Aug 20, 2024
ccecf36
Made prettier run on everything
mattpocock Aug 20, 2024
9bc2c99
Ran prettier on rollup
mattpocock Aug 20, 2024
5c87bc5
Ran prettier on typecheck tessts
mattpocock Aug 20, 2024
aa3d152
Added cache for ESLint
mattpocock Sep 6, 2024
ef30251
Prettier and eslint improvements (no upgrades yet)
mattpocock Aug 20, 2024
47f48a0
Made prettier run on everything
mattpocock Aug 20, 2024
2242608
Ran prettier on typecheck tessts
mattpocock Aug 20, 2024
d54dd46
Remove import type from typecheck tests
mattpocock Sep 6, 2024
e20505b
Fixed test
mattpocock Sep 6, 2024
8b55bb7
Merge branch 'matt/prettier-and-eslint-improvements--no-upgrades-yet-…
mattpocock Sep 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,11 @@ module.exports = {
node: true,
},
ignorePatterns: ['dist/', 'tests/'],
plugins: [
'@typescript-eslint',
],
plugins: ['@typescript-eslint'],
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/eslint-recommended',
'plugin:@typescript-eslint/recommended',
'prettier/@typescript-eslint',
'plugin:prettier/recommended'
],
rules: {
semi: 'off',
Expand All @@ -22,14 +18,17 @@ module.exports = {
'@typescript-eslint/explicit-function-return-type': 'off',
'@typescript-eslint/no-unused-vars': 'off',
'@typescript-eslint/interface-name-prefix': 'off',
'@typescript-eslint/member-delimiter-style': ['error', {
multiline: {
delimiter: 'none',
'@typescript-eslint/member-delimiter-style': [
'error',
{
multiline: {
delimiter: 'none',
},
singleline: {
delimiter: 'semi',
requireLast: false,
},
},
singleline: {
delimiter: 'semi',
requireLast: false
}
}]
],
},
};
}
18 changes: 9 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ jobs:
uses: actions/cache@v4
id: cache-dependencies
with:
path: "node_modules"
path: 'node_modules'
key: depends-node${{ env.RUNNER_NODE_VERSION }}-${{ hashFiles('package-lock.json') }}
- name: install dependencies
if: steps.cache-dependencies.outputs.cache-hit != 'true'
run: npm i

typecheck:
runs-on: ubuntu-latest
needs: install_deps
Expand All @@ -41,11 +41,11 @@ jobs:
- name: restore dependencies cache
uses: actions/cache/restore@v4
with:
path: "node_modules"
path: 'node_modules'
key: depends-node${{ env.RUNNER_NODE_VERSION }}-${{ hashFiles('package-lock.json') }}
- name: typecheck
run: npm run typecheck

lint:
runs-on: ubuntu-latest
needs: install_deps
Expand All @@ -58,10 +58,10 @@ jobs:
- name: restore dependencies cache
uses: actions/cache/restore@v4
with:
path: "node_modules"
path: 'node_modules'
key: depends-node${{ env.RUNNER_NODE_VERSION }}-${{ hashFiles('package-lock.json') }}
- name: lint
run: npm run lint
run: npm run lint && npm run format-check

build:
runs-on: ubuntu-latest
Expand All @@ -75,11 +75,11 @@ jobs:
- name: restore dependencies cache
uses: actions/cache/restore@v4
with:
path: "node_modules"
path: 'node_modules'
key: depends-node${{ env.RUNNER_NODE_VERSION }}-${{ hashFiles('package-lock.json') }}
- name: build
run: npm run build

test:
runs-on: ubuntu-latest
needs: install_deps
Expand All @@ -95,7 +95,7 @@ jobs:
- name: restore dependencies cache
uses: actions/cache/restore@v4
with:
path: "node_modules"
path: 'node_modules'
key: depends-node${{ env.RUNNER_NODE_VERSION }}-${{ hashFiles('package-lock.json') }}
- name: test
run: npm run test
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,3 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

3 changes: 3 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
tmp
dist
.changeset
6 changes: 3 additions & 3 deletions .prettierrc.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module.exports = {
semi: false,
trailingComma: "all",
trailingComma: 'all',
singleQuote: true,
printWidth: 100,
tabWidth: 2
};
tabWidth: 2,
}
Loading