safeTry should not require .safeUnwrap() #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: da80693 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dmmulroy
force-pushed
the
dmmulroy/symbol-iterator
branch
from
8dbc806 to
88ebd46
Compare
m-shaka
reviewed
Oct 11, 2024
m-shaka
reviewed
Oct 11, 2024
dmmulroy
force-pushed
the
dmmulroy/symbol-iterator
branch
4 times, most recently
from
eb0e07c to
c7d58a0
Compare
m-shaka
reviewed
Oct 12, 2024
dmmulroy
force-pushed
the
dmmulroy/symbol-iterator
branch
from
c7d58a0 to
4d3199c
Compare
dmmulroy
force-pushed
the
dmmulroy/symbol-iterator
branch
from
4d3199c to
609b398
Compare
@m-shaka I missed a |
m-shaka
approved these changes
Oct 19, 2024
supermacro
approved these changes
Oct 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #580
edit: Had to bump jest versions for support in using
toBeEqual()on classes/objects w/[Symbol.itereator]()and[Symbol.asyncIterator]()CC: @mattpocock @m-shaka @supermacro