Fix segmentation fault when matching regex string against non-string values #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crocodele
force-pushed
the
fix/RegexSegmentationFault
branch
from
fd07e8c to
1cbc017
Compare
dawitnida
reviewed
Jan 10, 2025
| } else if (Z_TYPE_P(lh) == IS_FALSE) { | ||
| zs_lh = zend_string_init("false", 5, 0); | ||
| } else { | ||
| zs_lh = zval_get_string(lh); |
There was a problem hiding this comment.
Do we need to call zend_string_init() again as the logic above already covers specific scalar types on line 300?
There was a problem hiding this comment.
Or long, double, etc are not handled so it would end up here?
There was a problem hiding this comment.
Line 300 is within the if for IS_OBJECT, so it covers objects that can be cast to string with __toString().
This else is indeed primarily for longs, doubles etc. that should be possible to cast to strings.
dawitnida
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #188.
I'm not very happy about the handling of booleans etc., but I don't think there's a perfect solution to that. If someone has ideas, feel free to suggest. By default,
truewould be cast to"1"andfalseto empty string"".