Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad filepath when the client is on a mac #304

Open
Draconad opened this issue Apr 15, 2023 · 2 comments
Open

Bad filepath when the client is on a mac #304

Draconad opened this issue Apr 15, 2023 · 2 comments
Labels
bug help wanted Mac Task is related to Mac OS needs testing This issue has a resolution or mitigation implemented but needs to be tested

Comments

@Draconad
Copy link

Draconad commented Apr 15, 2023

Serversync Version: 4.1.0

I have also tested 4.2.0 and the problem still persists on this version too.

Minecraft Version: 1.19.2

Issue: I have Serversync running on my server hosted on windows. My own windows cients can sync up and work seamlessly. However when I run the client on a macbook, instead of putting the mods in the mods folder, it puts them in the root directory of the minecraft instance, and renames them from example.jar to mods\example.jar

@rheimus rheimus added bug help wanted Mac Task is related to Mac OS labels Apr 22, 2023
@rheimus
Copy link
Collaborator

rheimus commented Apr 22, 2023

Presumably the way mac resolves paths is sufficiently different that serversync can not determine where it is being run from.

Could be several things, to list a few that I can think of:

  • The code that resolves the root directory could be busted on mac
  • The users install of java could be broken, some installs have java running from root rather than from the location of jar files

I don’t have access to apple hardware to test on so progress for this will most likely need to be a pull request from an interested dev.

Likely problem locations:

@rheimus
Copy link
Collaborator

rheimus commented Apr 22, 2023

This may also have been solved by #282

Not sure if I ever released a version with that fix in it.

@rheimus rheimus added this to the 4.3.0 milestone Dec 26, 2023
@rheimus rheimus added needs release This issue has been fixed but is not part of a released package and removed needs release This issue has been fixed but is not part of a released package labels Dec 26, 2023
@rheimus rheimus removed this from the 4.3.0 milestone Dec 26, 2023
@rheimus rheimus added the needs testing This issue has a resolution or mitigation implemented but needs to be tested label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted Mac Task is related to Mac OS needs testing This issue has a resolution or mitigation implemented but needs to be tested
Projects
None yet
Development

No branches or pull requests

2 participants