Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Server][Feature Request] Create connection whitelist/blacklist ability #45

Closed
rheimus opened this issue Jan 12, 2017 · 6 comments
Closed
Milestone

Comments

@rheimus
Copy link
Collaborator

rheimus commented Jan 12, 2017

Might as well allow the server to refuse connections

@rheimus rheimus self-assigned this Jan 12, 2017
@rheimus rheimus modified the milestones: 3, 2.7 Jan 12, 2017
@P3rf3ctXZer0
Copy link

Good plan in case someone attempt too many downloads.

@teetron9000
Copy link

A suggestion: utilize the banned-ips.json and whitelist.json of the minecraft server itself, if possible. (Griefers likely to abuse something like this = also likely candidates for bans... If an IP is banned from the server, maybe this should also treat it as banned.)

@rheimus
Copy link
Collaborator Author

rheimus commented Feb 27, 2017

Tis a good idea, could add a check for the existence of said files and pull in values present

@rheimus rheimus removed their assignment Jun 13, 2017
@rheimus rheimus changed the title Create connection whitelist/blacklist ability [Server][Feature Request] Create connection whitelist/blacklist ability Sep 21, 2017
@rheimus
Copy link
Collaborator Author

rheimus commented Apr 29, 2018

Work to be done:

  • [Client][Server] Implement file manager for sanity's sake #100 Implement a file manager class (sanity)
  • Implement knowledge of Minecraft and its folder structure
  • Add a section to the SS config to allow users to utilize minecrafts banned-ips/whitelist.json and/or the SS config (merge the two lists, might need an adapter)
  • Implement server-side connection handling

rheimus added a commit to rheimus/ServerSync that referenced this issue Mar 20, 2020
rheimus added a commit that referenced this issue Mar 20, 2020
#45 Add support for banned-ips.json
@rheimus
Copy link
Collaborator Author

rheimus commented Mar 20, 2020

Added support for using Minecrafts banned-ips.json. You should be able to either add entries manually to it or use server commands to ban addresses.
e.g. /ban-ip 127.0.0.1

Still need to plug in the whitelist.json file.

@rheimus
Copy link
Collaborator Author

rheimus commented Nov 7, 2020

Closing in favor of #216

@rheimus rheimus closed this as completed Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants