Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ upgrade code to handle surrealdb v2 #123

Merged
merged 21 commits into from
Oct 17, 2024
Merged

Conversation

Odonno
Copy link
Contributor

@Odonno Odonno commented Aug 20, 2024

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What does this change do?

Handle surrealdb v2

What is your testing strategy?

Integration tests

Is this related to any issues?

N/A

Have you read the Contributing Guidelines?

@J05HM0N5TER
Copy link

Hi. I am truly interested in this feature because v2 of surreal has some features that I could benefit from with my project. Is there any way I can help push this forwards?
I am not familiar with this code base, but I can at least help test this, and do some simple debugging if that would help.

@alniswar19
Copy link

seems this will solve issue #127

@armanradan
Copy link

I hope this pr gets merged soon. We really need it for V2

@armanradan
Copy link

@Odonno Would you please fix the issue with workflow so we can finally use v2 ?

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 44.49541% with 121 lines in your changes missing coverage. Please review.

Project coverage is 72.84%. Comparing base (6fd2105) to head (38f020c).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
SurrealDb.Net/Internals/SurrealDbEngine.Http.cs 39.79% 48 Missing and 11 partials ⚠️
SurrealDb.Net/Internals/SurrealDbEngine.Ws.cs 35.63% 47 Missing and 9 partials ⚠️
SurrealDb.Net/Models/Response/SurrealDbResponse.cs 50.00% 2 Missing and 1 partial ⚠️
SurrealDb.Net/SurrealDbClient.Methods.cs 88.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   69.65%   72.84%   +3.19%     
==========================================
  Files         161      148      -13     
  Lines        6702     5731     -971     
  Branches      775      625     -150     
==========================================
- Hits         4668     4175     -493     
+ Misses       1689     1287     -402     
+ Partials      345      269      -76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Odonno Odonno marked this pull request as ready for review October 6, 2024 13:26
@kearfy kearfy merged commit 515c383 into surrealdb:main Oct 17, 2024
7 checks passed
@Odonno Odonno deleted the feat/v2 branch October 18, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants