feat(vitest): vitest browser mode #588
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ad89510 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
dominikg
reviewed
Jun 9, 2025
| if (componentTesting) { | ||
| sv.devDependency('@vitest/browser', '^3.2.3'); | ||
| sv.devDependency('vitest-browser-svelte', '^0.1.0'); | ||
| sv.devDependency('playwright', '^1.0.0'); |
There was a problem hiding this comment.
would suggest picking the highest available playwright minor here, or at least the one that was available when vitest browser mode was introduced, i am not sure playwright 1.0.0 is actually compatible with it (playwright does breaking changes in minors unfortunately)
There was a problem hiding this comment.
Does it matter though? Users should always get the latest minor installed, assuming they havn't used playwright in their project before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports
vitestbrowser mode. Makes the setup more flexible by asking the user to add component / unit testing.Adds a new
object.createFromPrimitivesto core that should help us find the right balance for #557. We should allobject.createcalls in the future and try to use this wherever possible.todo:
The following Vite config options will be overridden by SvelteKit: - rootis acurate and how to avoid it