Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] sourcemap markup #6427

Merged
merged 3 commits into from
Jul 10, 2021
Merged

[feat] sourcemap markup #6427

merged 3 commits into from
Jul 10, 2021

Conversation

tanhauhau
Copy link
Member

Closes #6092

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@benmccann benmccann changed the title sourcemap markup [feat[ sourcemap markup Jun 30, 2021
@benmccann benmccann changed the title [feat[ sourcemap markup [feat] sourcemap markup Jun 30, 2021
benmccann
benmccann approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this marked as draft just to figure out if it's what we want? It looks like a good behavior to me

@tanhauhau
Copy link
Member Author

It was initially for discussion. But sure we can add some sourcemap for markup if it make sense

@tanhauhau tanhauhau marked this pull request as ready for review July 8, 2021 13:08
@tanhauhau tanhauhau merged commit 2cec6a9 into sveltejs:master Jul 10, 2021
@tanhauhau tanhauhau deleted the tanhauhau/gh-6092 branch July 10, 2021 04:12
@Conduitry Conduitry mentioned this pull request Jul 21, 2021
Closed
@benmccann benmccann mentioned this pull request Jul 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann approved these changes

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segment-less sourcemap generated for static templates
3 participants
@tanhauhau @benmccann @dummdidumm