Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use Node.js 22 for dev env #3720

Merged
merged 1 commit into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
node-version: [16.x, 18.x, 20.x, 22.x]

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -47,7 +47,7 @@ jobs:
- name: Build swagger-js
run: npm run build
- name: Upload commonjs build artifacts
if: startsWith(matrix.node-version, '20')
if: startsWith(matrix.node-version, '22')
uses: actions/upload-artifact@v4
with:
name: commonjs
Expand All @@ -60,10 +60,10 @@ jobs:

steps:
- uses: actions/checkout@v4
- name: Use Node.js 20
- name: Use Node.js 22
uses: actions/setup-node@v4
with:
node-version: 20
node-version: 22

- name: Cache Node Modules
id: cache-node-modules
Expand Down Expand Up @@ -116,3 +116,10 @@ jobs:
- name: Run commonjs build artifacts on Node.js 20.x
run: node -p "require('./commonjs')"

- name: Use Node 22.x
uses: actions/setup-node@v4
with:
node-version: 22.x
- name: Run commonjs build artifacts on Node.js 22.x
run: node -p "require('./commonjs')"

2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 20
node-version: 22

- name: Install dependencies
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.3.0
22.11.0
4 changes: 2 additions & 2 deletions docs/development/setting-up.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
### Prerequisites

- git, any version
- Node.js >=20.3.0
- NPM >=9.6.7
- Node.js >=22.11.0
- NPM >=10.9.0

### Setting up

Expand Down