Skip to content

Commit 22abef9

Browse files
committed
fix: copy QStringView by value
1 parent 8a1811c commit 22abef9

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/misc/simulation/fscommon/fsdirectories.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -653,7 +653,7 @@ namespace swift::misc::simulation::fscommon
653653
if (fileContent.isEmpty()) { continue; }
654654
const QList<QStringView> lines = splitLinesRefs(fileContent);
655655
static const QString p("Path=");
656-
for (const QStringView &line : lines)
656+
for (const QStringView line : lines)
657657
{
658658
const qsizetype i = line.lastIndexOf(p, -1, Qt::CaseInsensitive);
659659
if (i < 0 || line.endsWith('=')) { continue; }
@@ -779,7 +779,7 @@ namespace swift::misc::simulation::fscommon
779779
const QString relPath = fsxFileInfo.absolutePath();
780780

781781
QSet<QString> paths;
782-
for (const QStringView &line : lines)
782+
for (const QStringView line : lines)
783783
{
784784
const qsizetype i1 = line.lastIndexOf(p, -1, Qt::CaseInsensitive);
785785
if (i1 < 0) { continue; }
@@ -845,7 +845,7 @@ namespace swift::misc::simulation::fscommon
845845
const QString relPath = fsxFileInfo.absolutePath();
846846

847847
QSet<QString> paths;
848-
for (const QStringView &line : lines)
848+
for (const QStringView line : lines)
849849
{
850850
const qsizetype i1 = line.lastIndexOf(p, -1, Qt::CaseInsensitive);
851851
if (i1 < 0) { continue; }

src/misc/stringutils.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ namespace swift::misc
422422
{
423423
QMap<QString, QString> map;
424424
QList<QStringView> lines = splitLinesRefs(data);
425-
for (const QStringView &l : lines)
425+
for (const QStringView l : lines)
426426
{
427427
if (l.isEmpty()) { continue; }
428428
const qsizetype i = l.indexOf('=');

0 commit comments

Comments
 (0)