Reverts change for test targets and softens warning #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baujla
requested review from
aciidgh,
jakepetroules,
mirza-garibovic,
mhrawdon,
neonichu and
owenv
as code owners
|
@swift-ci please test |
|
@swift-ci please test |
jakepetroules
previously approved these changes
May 2, 2025
owenv
approved these changes
May 2, 2025
jakepetroules
approved these changes
May 2, 2025
ldaley
pushed a commit
to ldaley/swift-build
that referenced
this pull request
May 13, 2025
* Revert "Test targets emit incorrect 'The ENABLE_APP_SANDBOX build setting is set to NO, but is set to YES in your entitlements file.' warning (swiftlang#433)" This reverts commit 9ad44f1. * Removes app sandbox mismatch warning in some cases (rdar://150338157)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to revert the change we made for test targets and soften the warning as it's valid to have entitlements set to true while the sandbox build setting is set to NO implicitly.