Skip to content

[6.2] WatchKitTests.watchBackDeploymentArtifacts(): Make the check for the build version in arm64/arm64e slices in the WatchKit stub binary more permissive #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Tests/SWBBuildSystemTests/WatchKitTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,18 @@ fileprivate struct WatchKitTests: CoreBasedTests {
// Check expected deployment target
for slice in try macho.slices() {
let buildVersions = try Set(slice.buildVersions().map { $0.minOSVersion })
guard let buildVersion = buildVersions.only else {
let buildVersionsString = buildVersions.compactMap({ $0.description }).sorted().joined(separator: " ")
Issue.record("Expected one build version for architecture \(slice.arch) but found '\(buildVersionsString)'")
continue
}
switch slice.arch {
case "armv7k", "arm64_32", "x86_64":
#expect(buildVersions == [Version(2)])
#expect(buildVersion == Version(2))
case "arm64" where sdkPath.str.contains("WatchSimulator"):
#expect(buildVersions == [Version(7)])
#expect(buildVersion == Version(7))
case "arm64", "arm64e":
#expect(buildVersions == [Version(9)])
#expect(buildVersion >= Version(9))
case "i386":
break
default:
Expand Down
Loading