Skip to content

Commit 77bb234

Browse files
authored
WiX: simplify the SDK package definition (#209)
- Use durable GUID generation for auto-generation of the GUID. - Combine the platform definitions into a singular source to avoid drift. This avoids having to keep the variants in sync and provides an easier upgrade path. This is the first step towards enabling a non-admin experience for users.
1 parent 83477b1 commit 77bb234

File tree

6 files changed

+636
-1569
lines changed

6 files changed

+636
-1569
lines changed

platforms/Windows/sdk-amd64.wxs

Lines changed: 0 additions & 525 deletions
This file was deleted.

platforms/Windows/sdk-arm64.wxs

Lines changed: 0 additions & 525 deletions
This file was deleted.

platforms/Windows/sdk-x86.wxs

Lines changed: 0 additions & 517 deletions
This file was deleted.

platforms/Windows/sdk.wixproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<Import Project="WiXCodeSigning.targets" />
2020

2121
<PropertyGroup>
22-
<DefineConstants>ProductVersion=$(ProductVersion);PLATFORM_ROOT=$(PLATFORM_ROOT);SDK_ROOT=$(SDK_ROOT);SwiftShimsPath=$(SDK_ROOT)\usr\lib\swift\shims;</DefineConstants>
22+
<DefineConstants>ProductArchitecture=$(ProductArchitecture);ProductVersion=$(ProductVersion);PLATFORM_ROOT=$(PLATFORM_ROOT);SDK_ROOT=$(SDK_ROOT);SwiftShimsPath=$(SDK_ROOT)\usr\lib\swift\shims;</DefineConstants>
2323
<HarvestDirectoryAutogenerateGuids>false</HarvestDirectoryAutogenerateGuids>
2424
<HarvestDirectoryGenerateGuidsNow>true</HarvestDirectoryGenerateGuidsNow>
2525
<HarvestDirectoryNoLogo>true</HarvestDirectoryNoLogo>
@@ -40,6 +40,6 @@
4040
<DirectoryRefId>WindowsSDK_usr_lib_swift_shims</DirectoryRefId>
4141
<PreprocessorVariable>var.SwiftShimsPath</PreprocessorVariable>
4242
</HarvestDirectory>
43-
<Compile Include="sdk-$(ProductArchitecture).wxs" />
43+
<Compile Include="sdk.wxs" />
4444
</ItemGroup>
4545
</Project>

0 commit comments

Comments
 (0)