Remove workarounds for missing chdir support on Amazon Linux 2

Closes #8560

Author: jakepetroules

Sources/Basics/Concurrency/AsyncProcess.swift

@@ -18,7 +18,7 @@ import TSCLibc
 import Android
 #endif
 
-#if os(Linux)
+#if !os(Windows)
 #if USE_IMPL_ONLY_IMPORTS
 @_implementationOnly
 import func TSCclibc.SPM_posix_spawn_file_actions_addchdir_np_supported
@@ -621,24 +621,11 @@ package final class AsyncProcess {
         defer { posix_spawn_file_actions_destroy(&fileActions) }
 
         if let workingDirectory = workingDirectory?.pathString {
-            #if canImport(Darwin)
-            // The only way to set a workingDirectory is using an availability-gated initializer, so we don't need
-            // to handle the case where the posix_spawn_file_actions_addchdir_np method is unavailable. This check only
-            // exists here to make the compiler happy.
-            if #available(macOS 10.15, *) {
-                posix_spawn_file_actions_addchdir_np(&fileActions, workingDirectory)
-            }
-            #elseif os(FreeBSD)
-            posix_spawn_file_actions_addchdir_np(&fileActions, workingDirectory)
-            #elseif os(Linux)
             guard SPM_posix_spawn_file_actions_addchdir_np_supported() else {
                 throw AsyncProcess.Error.workingDirectoryNotSupported
             }
 
             SPM_posix_spawn_file_actions_addchdir_np(&fileActions, workingDirectory)
-            #else
-            throw AsyncProcess.Error.workingDirectoryNotSupported
-            #endif
         }
 
         var stdinPipe: [Int32] = [-1, -1]

Sources/_InternalTestSupport/SkippedTestSupport.swift

@@ -58,14 +58,4 @@ extension Trait where Self == Testing.ConditionTrait {
             #endif
         }
     }
-
-    /// Constructs a condition trait that causes a test to be disabled if the Foundation process spawning implementation
-    /// is not using `posix_spawn_file_actions_addchdir`.
-    public static var requireThreadSafeWorkingDirectory: Self {
-        disabled("Thread-safe process working directory support is unavailable.") {
-            // Amazon Linux 2 has glibc 2.26, and glibc 2.29 is needed for posix_spawn_file_actions_addchdir_np support
-            FileManager.default.contents(atPath: "/etc/system-release")
-                .map { String(decoding: $0, as: UTF8.self) == "Amazon Linux release 2 (Karoo)\n" } ?? false
-        }
-    }
 }

Sources/_InternalTestSupport/XCTAssertHelpers.swift

@@ -317,21 +317,3 @@ public struct CommandExecutionError: Error {
     public let stdout: String
     public let stderr: String
 }
-
-/// Skips the test if running on a platform which lacks the ability for build tasks to set a working directory due to lack of requisite system API.
-///
-/// Presently, relevant platforms include Amazon Linux 2 and OpenBSD.
-///
-/// - seealso: https://github.com/swiftlang/swift-package-manager/issues/8560
-public func XCTSkipIfWorkingDirectoryUnsupported() throws {
-    func unavailable() throws {
-        throw XCTSkip("https://github.com/swiftlang/swift-package-manager/issues/8560: Thread-safe process working directory support is unavailable on this platform.")
-    }
-    #if os(Linux)
-    if FileManager.default.contents(atPath: "/etc/system-release").map({ String(decoding: $0, as: UTF8.self) == "Amazon Linux release 2 (Karoo)\n" }) ?? false {
-        try unavailable()
-    }
-    #elseif os(OpenBSD)
-    try unavailable()
-    #endif
-}

Tests/BasicsTests/Archiver/TarArchiverTests.swift

@@ -104,7 +104,7 @@ final class TarArchiverTests: XCTestCase {
     }
 
     func testCompress() async throws {
-        #if os(Linux)
+        #if !os(Windows)
         guard SPM_posix_spawn_file_actions_addchdir_np_supported() else {
             throw XCTSkip("working directory not supported on this platform")
         }

Tests/BasicsTests/Archiver/UniversalArchiverTests.swift

@@ -135,7 +135,7 @@ final class UniversalArchiverTests: XCTestCase {
     }
 
     func testCompress() async throws {
-        #if os(Linux)
+        #if !os(Windows)
         guard SPM_posix_spawn_file_actions_addchdir_np_supported() else {
             throw XCTSkip("working directory not supported on this platform")
         }

Tests/BasicsTests/Archiver/ZipArchiverTests.swift

@@ -112,7 +112,7 @@ final class ZipArchiverTests: XCTestCase {
     }
 
     func testCompress() async throws {
-        #if os(Linux)
+        #if !os(Windows)
         guard SPM_posix_spawn_file_actions_addchdir_np_supported() else {
             throw XCTSkip("working directory not supported on this platform")
         }
@@ -178,4 +178,4 @@ final class ZipArchiverTests: XCTestCase {
              )
          }
      }
-}
+}

Tests/BasicsTests/AsyncProcessTests.swift

@@ -389,12 +389,7 @@ final class AsyncProcessTests: XCTestCase {
     }
 
     func testWorkingDirectory() throws {
-        guard #available(macOS 10.15, *) else {
-            // Skip this test since it's not supported in this OS.
-            return
-        }
-
-        #if os(Linux) || os(Android)
+        #if !os(Windows)
         guard SPM_posix_spawn_file_actions_addchdir_np_supported() else {
             // Skip this test since it's not supported in this OS.
             return

Tests/CommandsTests/PackageRegistryCommandTests.swift

@@ -334,7 +334,7 @@ final class PackageRegistryCommandTests: CommandsTestCase {
     // TODO: Test example with login and password
 
     func testArchiving() async throws {
-        #if os(Linux)
+        #if !os(Windows)
         // needed for archiving
         guard SPM_posix_spawn_file_actions_addchdir_np_supported() else {
             throw XCTSkip("working directory not supported on this platform")
@@ -457,7 +457,7 @@ final class PackageRegistryCommandTests: CommandsTestCase {
     }
 
     func testPublishingToHTTPRegistry() throws {
-        #if os(Linux)
+        #if !os(Windows)
         // needed for archiving
         guard SPM_posix_spawn_file_actions_addchdir_np_supported() else {
             throw XCTSkip("working directory not supported on this platform")
@@ -499,7 +499,7 @@ final class PackageRegistryCommandTests: CommandsTestCase {
     }
 
     func testPublishingToAllowedHTTPRegistry() async throws {
-        #if os(Linux)
+        #if !os(Windows)
         // needed for archiving
         guard SPM_posix_spawn_file_actions_addchdir_np_supported() else {
             throw XCTSkip("working directory not supported on this platform")
@@ -584,7 +584,7 @@ final class PackageRegistryCommandTests: CommandsTestCase {
     }
 
     func testPublishingUnsignedPackage() throws {
-        #if os(Linux)
+        #if !os(Windows)
         // needed for archiving
         guard SPM_posix_spawn_file_actions_addchdir_np_supported() else {
             throw XCTSkip("working directory not supported on this platform")
@@ -749,7 +749,7 @@ final class PackageRegistryCommandTests: CommandsTestCase {
             "skipping because test environment doesn't support concurrency"
         )
 
-        #if os(Linux)
+        #if !os(Windows)
         // needed for archiving
         guard SPM_posix_spawn_file_actions_addchdir_np_supported() else {
             throw XCTSkip("working directory not supported on this platform")